commit 82f1cb9aac57634234312b0968c832928b30af01
from: Markus Uhlin <markus@nifty-networks.net>
date: Tue Aug 19 00:45:41 2025 UTC

Fixed hardcoded flags and modes passed to open()

commit - 50a969b7ac35bc33a78d07ae3aa7bc19a13b7378
commit + 82f1cb9aac57634234312b0968c832928b30af01
blob - dfe528e65dac856000ea4b081ef17ff405b05d53
blob + 9f192bc6d290409f9196be26577c9c715ffa2643
--- FICS/adminproc.c
+++ FICS/adminproc.c
@@ -28,6 +28,7 @@
 #include "command.h"
 #include "comproc.h"
 #include "fics_getsalt.h"
+#include "ficsmain.h"
 #include "gamedb.h"
 #include "gameproc.h"
 #include "maxxes-utils.h"
@@ -188,7 +189,7 @@ create_news_file(int p, param_list param, int admin)
 			msnprintf(filename, sizeof filename, "%s/adminnews.%d",
 			    news_dir,
 			    param[0].val.integer);
-			fd = open(filename, O_WRONLY|O_CREAT, S_IWUSR|S_IRUSR);
+			fd = open(filename, g_open_flags[1], g_open_modes);
 			if (fd < 0)
 				return COM_FAILED;
 			else if ((fp = fdopen(fd, "w")) != NULL) {
@@ -205,7 +206,7 @@ create_news_file(int p, param_list param, int admin)
 			msnprintf(filename, sizeof filename, "%s/news.%d",
 			    news_dir,
 			    param[0].val.integer);
-			fd = open(filename, O_WRONLY|O_CREAT, S_IWUSR|S_IRUSR);
+			fd = open(filename, g_open_flags[1], g_open_modes);
 			if (fd < 0)
 				return COM_FAILED;
 			else if ((fp = fdopen(fd, "w")) != NULL) {
@@ -229,7 +230,7 @@ add_item(char *new_item, char *filename)
 
 	msnprintf(tmp_file, sizeof tmp_file, "%s/.tmp.idx", news_dir);
 
-	fd = open(tmp_file, O_WRONLY|O_CREAT, S_IWUSR|S_IRUSR);
+	fd = open(tmp_file, g_open_flags[1], g_open_modes);
 
 	if (fd < 0)
 		return 0;
blob - 0d1e7d48d524db8a149421ae4e2737f33ae5920d
blob + 9919bfd1d0db6f1aa418fbb1f69b275eb7fecd78
--- FICS/playerdb.c
+++ FICS/playerdb.c
@@ -1208,7 +1208,7 @@ player_markdeleted(int p)
 	xrename(__func__, fname, fname2);
 
 	errno = 0;
-	fd = open(fname2, O_WRONLY|O_CREAT, S_IWUSR|S_IRUSR);
+	fd = open(fname2, g_open_flags[0], g_open_modes);
 
 	if (fd < 0) {
 		warn("%s: open", __func__);
@@ -1347,7 +1347,7 @@ player_save(int p)
 	    parray[p].login[0], parray[p].login);
 
 	errno = 0;
-	fd = open(fname, O_WRONLY|O_CREAT, S_IWUSR|S_IRUSR);
+	fd = open(fname, g_open_flags[1], g_open_modes);
 
 	if (fd < 0) {
 		warn("%s: Problem opening file %s for write", __func__, fname);
@@ -1644,7 +1644,7 @@ write_p_inout(int inout, int p, char *file, int maxlin
 	int	 fd;
 
 	errno = 0;
-	fd = open(file, O_WRONLY|O_CREAT, S_IWUSR|S_IRUSR);
+	fd = open(file, g_open_flags[0], g_open_modes);
 
 	if (fd < 0) {
 		warn("%s: open", __func__);
@@ -2639,7 +2639,7 @@ player_add_message(int top, int fromp, char *message)
 		return -1;
 
 	errno = 0;
-	fd = open(fname, O_WRONLY|O_CREAT, S_IWUSR|S_IRUSR);
+	fd = open(fname, g_open_flags[0], g_open_modes);
 
 	if (fd < 0)
 		return -1;
@@ -2817,7 +2817,7 @@ WriteMsgFile(int p, textlist *Head)
 	GetMsgFile(p, fName, sizeof fName, __func__);
 
 	errno = 0;
-	fd = open(fName, O_WRONLY|O_CREAT, S_IWUSR|S_IRUSR);
+	fd = open(fName, g_open_flags[1], g_open_modes);
 
 	if (fd < 0)
 		return 0;
@@ -3238,7 +3238,7 @@ player_add_comment(int p_by, int p_to, char *comment)
 	    parray[p_to].login[0], parray[p_to].login, "comments");
 
 	errno = 0;
-	fd = open(fname, O_WRONLY|O_CREAT, S_IWUSR|S_IRUSR);
+	fd = open(fname, g_open_flags[0], g_open_modes);
 
 	if (fd < 0) {
 		warn("%s: open", __func__);
blob - e1306562c6c315a6d989cfca2369fc5529e0f690
blob + a85776d1f74f3377e1dc3fe83fb62f511fedb419
--- FICS/ratings.c
+++ FICS/ratings.c
@@ -51,6 +51,7 @@
 #include "command.h"
 #include "comproc.h"
 #include "config.h"
+#include "ficsmain.h"
 #include "gamedb.h"
 #include "lists.h"
 #include "playerdb.h"
@@ -418,7 +419,7 @@ save_ratings(void)
 	    STATS_VERSION);
 
 	errno = 0;
-	fd = open(fname, O_WRONLY|O_CREAT, S_IWUSR|S_IRUSR);
+	fd = open(fname, g_open_flags[1], g_open_modes);
 
 	if (fd < 0) {
 		warn("%s: can't write ratings data", __func__);
@@ -1501,7 +1502,7 @@ UpdateRank(int type, char *addName, statistics *sNew, 
 	snprintf(TmpRankFile, sizeof TmpRankFile, "%s/tmpRank", sdir);
 
 	errno = 0;
-	fd = open(TmpRankFile, O_WRONLY|O_CREAT, S_IWUSR|S_IRUSR);
+	fd = open(TmpRankFile, g_open_flags[1], g_open_modes);
 
 	if (fd < 0) {
 		warn("%s: open", __func__);
blob - 4e47b8f0abc0fb4d2a080a627254e2dcda50585c
blob + 4da2411aa2fe510da444ce1cd81cad87efef780b
--- FICS/utils.c
+++ FICS/utils.c
@@ -56,6 +56,7 @@
 #include <string.h>
 
 #include "config.h"
+#include "ficsmain.h"
 #include "network.h"
 #include "playerdb.h"
 #include "rmalloc.h"
@@ -905,7 +906,7 @@ truncate_file(char *file, int lines)
 		int fd;
 
 		errno = 0;
-		fd = open(file, O_WRONLY|O_CREAT, S_IWUSR|S_IRUSR);
+		fd = open(file, g_open_flags[1], g_open_modes);
 
 		if (fd < 0) {
 			warn("%s: open", __func__);