Commits

ngIRCd 20~rc1

Update Xcode project files

conf.c: Use strlcpy() instead of strcpy() This fixes the following warning of gcc on OpenBSD 5.0: conf.c:728: warning: strcpy() is almost always misused, please use strlcpy()

tool.h: Don't check for and #define PF_INET This is correctly handled by ipaddr/ng_ipaddr.h today, and the check in tool.h isn't required any more -- and caused errors on OpenBSD 5.0: In file included from ./../tool/tool.h:23: /usr/include/arpa/inet.h:74: warning: "struct in_addr" declared inside parameter list

conf-ssl.h: Use "gnutls_session_t" instead of "gnutls_session" This fixes the following warning with current versions of GnuTLS: conf-ssl.h:36: warning: "gnutls_session" is deprecated

Add new IRC+ server flag "X": "XOP modes supported" This flag indicates, that the server supports the enhanced "xop channel user modes", like channel owner, admin, and halfop. This information is used to make sure that no unsupported CHANINFO commands are sent to servers not supporting such mode prefixes, for example.

Update autoconf/automake version numbers in doc/HowToRelease.txt

Update NEWS and ChangeLog files

Remove Anope "ngircd" protocol module patches Starting with Anope 1.9.8, the ngIRCd protocol module is included in the Anope distribution, so there's no longer any need to support our own (but now heavily outdated!) patches. Therefore remove them.

doc/Services.txt: Update documentation for Anope 1.9.8 Starting with Anope 1.9.8, the ngIRCd protocol module is rewritten from scratch by "DukePyrolator" and included in the Anope distribution. So no patching is required any more, yeah! Drawback: Anope 1.9.8 is in development and not yet released ...

Correctly add irc-metadata.{c|h} to Makefile.ng ...

doc/Protocol.txt: Document METADATA command

Generate "METADATA host" commands on "MODE +/-x" Use "METADATA host" commands to let servers supporting this command know which (possibly cloaked) hostname is in effect for a specific client. This prevents "double cloaking" of hostnames and even cloaked hostnames are in sync on all servers supporting "METADATA" now.

Don't cloak already cloaked hostname when using METADATA A client for which a METADATA command has been received from one of its peers got the client flag "M" set. So it's safe to assume that such a client gets "METADATA host" commands for its cloaked hostname and the server must not cloak the hostname on its own, even when the client mode "+x" is set.

Implement METADATA command to update client metadata The METADATA command can be used by other servers to update "metadata" of registered clients, like the client info text ("real name"), user name, and hostname: : METADATA : It is distributed in the network, unknown names are silently ignored and passed on, too. This allows for further extensions.

doc/Protocol.txt: add/fix CHARCONV description

PredefChannelsOnly: Fix message for non pre-defined channels If PredefChannelsOnly is enabled, and if someone tries to create a channel which does not exist, then the error message is a 474. The 474 Error message changed recently and does not match anymore: 'Cannot join channel (+b) -- You are banned'. Changed the error message to numeric 403 'No such channel'. Bug introduced by commit 9a82304a. (cherry picked from commit 2c2e08f34187a33c1da745995c5f213e33a91410)

Test suite: add some "remote checks" to whois-test.e

Send NICK commands with prefix of (target) user Now NICK commands are always generated using the prefix of the target user, even when the nickname change has been initiated by some other (pseudo) server or using the SVSNICK command. In this case, the prefix of the initiator has been used, but this isn't compatible with clients (at least weechat and irssi don't handle such NICK commands correctly).

Update doc/Services.txt, sort services alphabetically

Implement SVSNICK command to change remote nicknames The SVSNICK command allows other servers (and services on "pseudo-servers") to forcefully change nicknames of remote users. Syntax: ": SVSNICK " The SVSNICK command itself doesn't change the nickname, but it becomes forwarded to the server to which the user is connected to. And then this server initiates the real nickname changing using regular NICK commands. This allows to still run networks with old servers not supporting the SVSNICK command, because SVSNICK commands for nicknames on such servers are silently ignored and don't cause a desync of the network.

IRC_NICK(): Code cleanup, new function Change_Nick()

Spelling fix: "nick name" -> "nickname"

Xcode: correctly #define PACKAGE and PACKAGE_NAME

Fix warning message introduced when cleaning up IRC_SERVER() This reverts a not intentional code change and fixes the following compiler warning message (tested with gcc 4.4.5): irc-server.c: In function "IRC_SERVER": irc-server.c:142: warning: suggest parentheses around operand of "!" or change "&" to "&&" or "!" to "~"

Make server reconnect time a little bit more random Add randomly up to 15 seconds to the reconnect delay for outgoing server links when the connection has been "short" and therefore the "ConnectRetry" delay is being enforced. This should make it even more unlikely that two servers deadlock each other when both are trying to connect to the other one at the same time, for example in test environments.

Don't accept connections for servers already beeing linked If two servers try to link each other, there was a time frame that could result in one connection overwriting the other, e. g. the incoming connection overwriting the status of the outgoing one. And this could lead to all kind of weirdness (even crashes!) later on. So now such incoming connections are dropped. But this most probably prevents the two servers from linking until timing changes somehow (network latency?) because each server drops the incoming connection of the other one, so no connection survives in the end. But this has to be addressed by an other patch ...

IRC_SERVER(): Code cleanup

Use lowercase "package name" for syslog logging again This is how ngIRCd up to release 19.2 behaved; "bug" introduced by commit 67e882, "configure.in: require autoconf 2.67 and automake 1.11", which changed the "PACKAGE_NAME" to "ngIRCd"; so use "PACKAGE" which still is the lowercase version for initializing syslog logging.

Document new configuration option "MaxListSize"

Make the maximum /list reply length a configurable limit.

Update NEWS and ChangeLog files

Allow remote servers and IRC Ops to change channel topics Remote servers are always allowed to change all channel topics, and IRC Operators are allowed to change all channel topics if the configuration option "OperCanUseMode" is enabled. Bug introduced by commit 7b01bb8 and reported by DNS777.

Increased maximum number of possible user and channel modes Currntly ngIRCd supports 13 user and 15 channel modes, because there have been quite a few additions since our last release. But our data structures can only hold 15 user and -- even worse! -- only 9 channel modes! So enlarge the buffers to 20 bytes (actually 21 including NULL) to allow storing of all mode characters and to have some space left for more modes to come ... (cherry picked from commit 8996d777621d88d4bcc439ab4792b2814920687f)

Update error messages for user mode +b and channel Mode +M. Replaced error message for channel mode +M with ERR_NEEDREGGEDNICK_MSG (used by Bahamut, inspircd, ircu & Unreal too) and using numeric 477 and the msg simliar like inspircd. Replaced the error message ERR_CANNOTSENDTONICK_MSG for user mode +b with ERR_NONONREG_MSG and using numeric 486, similar like unrealircd. (cherry picked from commit 55a61ab17f63a9e757b7c7598c31b98ce5a132e8 and commit 3737d9ab7da1ea0485cefc07c65dc5308bf0db02)

Test suite: add more checks to whois-test.e

Add "i586/pc/haiku" to doc/Platforms.txt

Disable UID/GID checks on "single user OS" Don't abort on "single user operating systems" that don't know more than one user account and therefore can't change user and group IDs. Currently, the only such system supported by ngIRCd is Haiku, a BeOS clone.

Search gethostbyname() in libbind and libnetwork This is required for Haiku (BeOS clone) at least.

Update manual pages Among other little things, bring project description in line with website.

Test suite: add test for user mode "b"

Implement user mode "b": block messages When a user has set mode "b", all private messages and notices to this user are blocked if they don't originate from a registered user, an IRC Op, server or service. The originator gets an error numeric sent back in this case, ERR_CANNOTSENDTONICK_MSG(976), which is/was(?) used by KineIRCd, too. This closes bug #144.

Fix ERR_CANNOTSENDTOCHAN_MSG message This error message is not only used if one can not send to a channel because it is moderated, but for _all_ reasons when a message can not be delivered (moderated, banned, no external messages, ...), so strip the "(+m) -- Moderated" part of the error message again. Bug introduced by commit 9a82304a.

Shorten filenames of Anope protocol module patchfiles Filenames have been too long and couldn't be stored in all tar archive formats ...

WHOIS: show RPL_WHOISHOST_MSG to all IRC Ops in the network Not only show RPL_WHOISHOST_MSG to local IRC opreators, but show it to all IRC operators in the network. And don't show it to anybody if the "more privacy" configuration option is enabled. This closes bug #134.

Test suite: make expect scripts more verbose Now tests.sh transforms each expect script it executes using sed(1) and inserts a 'puts -nonewline stderr "."' in front of each "expect" command.

Test suite: remove indentation of messages

Merge branch 'bug141-ModesQq' This closes bug #141. * bug141-ModesQq: KICK-protect IRC services Implement channel mode "Q" and user mode "q" Conflicts: src/ngircd/defines.h src/ngircd/messages.h

Show active user modes in WHOIS reply Implement numeric RPL_WHOISMODES_MSG(379) and show user modes in the reply of the WHOIS command for the user himself or, if MorePrivacy isn't set, for request initiated by an IRC operator. Numeric 379 is used by Unreal and InspIRCd for this purpose, too. Closes bug #129.

KICK-protect IRC services

Implement channel mode 'V' (invite disallow) If the new channel mode "V" is set, the INVITE command becomes invalid and all clients get the new ERR_NOINVITE_MSG(518) reply. Unreal and InspIRCd uses this mode, too. This closes bug #143.

Implement channel mode "Q" and user mode "q" Both modes protect users from channel kicks: only IRC operators and servers can kick users having mode "q" or in channels with mode "Q". Original patch by DNS777 , thanks! This closes bug #141.

Allow channel admins to "de-admin" channel members This patch fixes unsetting of channel user mode "+a" (channel admin) and adds a better error message: without this patch, a channel admin is unable to unset this mode. This closes bug #142.

Define HAVE_SETSID for Mac OS X Xcode builds

Merge branch 'bug109-CHARCONV' This closes bug #109. * bug109-CHARCONV: Debian: require "telnet" or "telnet-ssl" for building Debian ngircd-full[-dbg]: enable CHARCONV Add "CHARCONV" to "feature string" when enabled Implement new IRC+ "CHARCONV" command Added new configure option "--with-iconv" Conflicts: src/ngircd/messages.h

Fix spelling: ERR_CHANOPPRIVTOLOW_MSG -> ERR_CHANOPPRIVTOOLOW_MSG Thanks to DNS for pointing this out, see bug #126!

Debian: require "telnet" or "telnet-ssl" for building

Makefile.am: don't use "make -C", it isn't portable

Debian ngircd-full[-dbg]: enable CHARCONV

Test suite: don't use "mkdir -p" "mkdir -p" is not supported on all platforms. Tested with Apple A/UX 3.1.x.

ERR_CHANNELISFULL_MSG: better wording (cherry picked from commit 0fcfa7e00fa8e098dd3724c7188c88ac82a52881)

Add "CHARCONV" to "feature string" when enabled

Fix getpid.sh to work on Apple A/UX again

Implement new IRC+ "CHARCONV" command See bug 109 and doc/Protocol.txt for details and documentation.

Send RPL_REHASHING if rehash was accepted (cherry picked from commit f1b171a09cd076f743a7fff221fa7aa752abb374)

Added new configure option "--with-iconv" The iconv library should be used for implementing the new CHARCONV IRC command discussed in bug 109. And because CHARCONV will be an IRC+ feature, we only test for libiconv if IRC+ is enabled as well.

Change variable name "SSLDHFile" to "DHFile" in log messages (cherry picked from commit d96db0a2e56d310177edb45d0a8b164a37992ab1)

Sort "feature string" alphabetically

Move ConnSSL_InitLibrary() "dummy" from header into C file (cherry picked from commit 5fd88c81a70d0c9e627f08522e57d251586288eb)

Include CAP command even when using "strict RFC mode"

NJOIN: correctly reset channel level flags This fixes commit 7b01bb83. Bug reported by DNS777 , thanks!

Merge branch 'autoconf-update' Update GNU autoconf and automake infrastructure. Tested on modern systems as well as Apple A/UX :-) * autoconf-update: AUTOMAKE_OPTIONS: fix ansi2knr option, include path Don't use AC_FUNC_MALLOC and AC_FUNC_REALLOC Make our own targets "silent", if enabled configure.in: use AC_CHECK_{FUNCS|HEADERS}_ONCE Updated config.{guess|sub} to version 2012-08-14 Make autogen.sh more verbose when VERBOSE=1 is set configure.in: use AC_SEARCH_LIBS (not AC_CHECK_LIB) configure.in: use AS_HELP_STRING macro configure.in: use AC_CANONICAL_HOST (not AC_CANONICAL_TARGET) configure.in: inttypes.h is an optional header file Use HAVE_SETSID #define when testing for setsid() Don't include , it is included by "portab.h" Don't check type.h availability, it is required configure.in: Use AC_CONFIG_FILES macro configure.in: Don't use AC_C_PROTOTYPES configure.in: Update checks for required and optional features configure.in: require autoconf 2.67 and automake 1.11 configure.in: sort some lists (templates, output, ...)

Simplify check for valid user names in IRC_USER(). Patches from Federico G. Schwindt, thanks! (cherry picked from commit a44b7126227ba1118ec02b399e31b08102af5e8c and 6fbe9583753b2620da275676cde46a89cb4d06c2)

AUTOMAKE_OPTIONS: fix ansi2knr option, include path Set correct relative path to ansi2knr.c in AUTOMAKE_OPTIONS, so that ansi2knr.{1|c} is only included once in the distribution archive.

Allow limited punctuation in usernames, for better PAM integration.

Allow user mode +x only when "CloakHostModeX" is set Allow users to "cloak" their hostname only when the configuration variable "CloakHostModeX" (introduced in 19.2) is set. Otherwise, only IRC opertators, other servers, and services are allowed to set mode +x. This prevents regular users from changing their hostmask to the name of the IRC server itself, which confused quite a few people ;-) This fixes bug #133.

Don't use AC_FUNC_MALLOC and AC_FUNC_REALLOC We don't expect the GNU'ish behaviour of of malloc() and realloc() and never implemented the replacement functions rpl_malloc()/rpl_realloc() -- so these test result in linking failues on systems that don't have a GNU'ish malloc() and realloc() even though we don't require it! Introduced by commit 47ad9afc.

Merge pull request #2 from briancollins/master Fix IRC_Send_NAMES not sending correct prefix for certain clients.

New configuration option "OperChanPAutoOp" If disabled, IRC operators don't become channel operators in persistent channels when joining. Enabled by default, which has been the behavior of ngIRCd up to this patch. Closes bug #135. (Cosmetic fixes by Alex.)

Make our own targets "silent", if enabled

Correctly re-initialize signal handlers on RESTART This fixes part 2 of bug #127 :-)

Fix NAMES response when client has multi-prefix Two fixes here: IRC_Send_NAMES was checking the capability of the wrong client when responding, and it didn't return any prefix for clients that had either +v or +o but not both.

Allow opers to see secret (+s) channels in LIST command As long as 'MorePrivacy' isn't enabled in the configuration file, local IRC operators can see secret (+s) channels when using the LIST command. Closes bug #136.

configure.in: use AC_CHECK_{FUNCS|HEADERS}_ONCE

New_Connection(): mark "IsSSL" parameter as UNUSED This fixes the following warning message when building without SSL support: conn.c: In function "New_Connection": conn.c:1365: warning: unused parameter "IsSSL" Introduced by commit 01b62202.

Merge branch 'better-chan-errors' By Alexander Barton (1) and DNS777 (1) * better-chan-errors: Remove unused ERR_CANNOTSENDTOCHAN2_MSG message Add some more information to channel error numerics

configure: only use AM_PROG_AR when available This fixes commit 78d189fb on systems with older automake ...

Updated config.{guess|sub} to version 2012-08-14

Show a warning on startup if config file is not a full path ngIRCd is a long-running process and changes its working directory to "/" to not block mounted filesystems and the like when running as daemon ("not in the foreground"); therefore the path to the configuration file must be relative to "/" (or the chroot() directory), which basically is "not relative", to ensure that "kill -HUP" and the "REHASH" command work as expected later on. This fixes parts of bug #127.

Merge branch 'move-connection-password' of git://arthur.barton.de/ngircd-alex This patch series converts the statically allocated password buffer in the CLIENT structure into a dynamically (and only when needed) allocated buffer which is referenced by the CONNECTION structure. This a) saves memory for clients not using passwords at all and b) allows for "arbitrarily" long passwords. By Brett Smith (5) and Alexander Barton (2). * 'move-connection-password' of git://arthur.barton.de/ngircd-alex: Login_User(): use "conn" insted of calling Client_Conn(Client) Free already saved password when storing a new one Indentation and style fixes. Connection password is not constant. Implementation clean-ups. Dynamically allocate memory for connection password. Move client password from the Client to the Connection struct.

Remove unused ERR_CANNOTSENDTOCHAN2_MSG message

Remove all geneerated Makefile.am on "make maintainer-clean"

Make autogen.sh more verbose when VERBOSE=1 is set

Create &SERVER channel after predefined channels This patch allows you to define &SERVER in a [Channel] block yourself and to overwrite the built-in topic and channel modes. Fixes bug #131.

Login_User(): use "conn" insted of calling Client_Conn(Client)

Add some more information to channel error numerics

Enhance "ServiceMask" to handle a list of masks The "ServiceMask" variable in "Server" blocks now can handle more than one mask using the new MatchCaseInsensitiveList() function. This makes marking "service clients" much more specific, which is a good thing per se, but which is the prerequisite for reasonably blocking these nick names, too (see commit a6dd2e3 for details).

Rename configure.in to configure.ac This fixes automake: warning: autoconf input should be named 'configure.ac', not 'configure.in' when running the autogen.sh script.

configure.in: use AC_SEARCH_LIBS (not AC_CHECK_LIB) Use the AC_SEARCH_LIBS macro to test for "sometimes but not always" required libraries, not AC_CHECK_LIB.

WHO #channel: don't limit list size It makes no sense to limit the list size when doing WHO for a channel and not to return all the users in that channel, so I removed the check. But if there are more than MAX_RPL_WHO(25) replies, the client requesting the list will be "penalized" one second more (then 2 in total). This fixes bug #125.

Free already saved password when storing a new one This shouldn't happen (clients aren't allowed to send more than one PASS command), but who knows ...

New function MatchCaseInsensitiveList() to check list of patterns

configure.ng: use AM_PROG_AR to check ar(1) command This fixes automake-1.12/am/library.am: warning: 'libngipaddr.a': linking libraries using a non-POSIX .../automake-1.12/am/library.am: archiver requires 'AM_PROG_AR' in 'configure.in' src/ipaddr/Makefile.am:12: while processing library 'libngipaddr.a' and similar warnings of automake.

configure.in: use AS_HELP_STRING macro

Define EV_SET() for kqueue() on systems that don't have it Some systems, notably FreeBSD 4.x, do have the kqueue() function but lack the definition of EV_SET() in their header files -- but don't worry, we can #define it on our own ;-) Definition taken from /usr/include/sys/event.h of FreeBSD 8.1. Patch tested on FreeBSD 4.1 by Götz Hoffart. Thanks!

Block nicknames that are reserved for services This patch introduces the new function Conf_NickIsBlocked() which checks if a given nick name matches with the "service mask" of a configured server. And Client_CheckNick() uses this information to deny such names for regular IRC users. So nick names intended for IRC services are more protected and can't be used by regular users even when the "services pseudo-server" isn't connected to the network. But please note: Up to now, there can be only one "ServiceMask" pattern per server, which most probably blocks much more nick names than really required ... So "ServiceMask" should allow more than one pattern which can be more specific, and most probably it should be possible to block nick names in the global server configuration as well. Nick names introduced by other servers/services are never restricted.

Indentation and style fixes.

Merge branch 'automake-am11-am12' * automake-am11-am12: autogen.sh: detect automake version format a.b.c and a.b configure.ng: don't require GIT tree to detect version string Include .mailmap file in distribution archives Include all build-system files into distribution archives Change build system to support new and old GNU automake

configure.in: use AC_CANONICAL_HOST (not AC_CANONICAL_TARGET) See the autoconf manual for details: http://www.gnu.org/software/autoconf/manual/autoconf.html#Specifying-Target-Triplets

Fix contrib/Makefile.am to list all files in EXTRA_DIST

Rename Conf_IsService() to Conf_NickIsService()

Connection password is not constant. Saying otherwise makes a warning when we assign this to conv.appdata_ptr in pam.c.

autogen.sh: detect automake version format a.b.c and a.b

INSTALL: update GNU automake/autoconf requirements

configure.in: inttypes.h is an optional header file

Update project description

Check_Connections(): code cleanup

Implementation clean-ups. * Have Conn_Password return an empty string when no password has been set, to play better with pam.c. * Use strdup in Conn_SetPassword.

configure.ng: don't require GIT tree to detect version string

automake: don't use INCLUDES, it's AM_CPPFLAGS nowadays

Use HAVE_SETSID #define when testing for setsid()

New function Conn_StartLogin() to finish connection initialization Conn_StartLogin() is called after the connection has been established and fully innitialized, including the SSL handshake, for example. Up to this patch, the "NoticeAuth" option broke the SSL handshake ...

Dynamically allocate memory for connection password.

Xcode: use certificate of Alex for code signing When doing non-debug Xcode builds, use the "Developer ID Application: Alexander Barton" certificate for code signing by default.

Include .mailmap file in distribution archives

automake: enable colored test output, if available The "color-tests" option can't be checked for, but is available starting with automake 1.11 which introduced AM_SILENT_RULES -- so we check this ...

Don't include , it is included by "portab.h"

Convert CONN_ID and Conf_MaxConnections to "int" datatype We can't handle more connections than accept(2) can supply, and accept(2) returns an "int" ...

Move client password from the Client to the Connection struct. This is a relatively naive implementation, basically doing the bare minimum necessary to make the switchover go. Subsequent commits can focus on improving the implementation.

"make uninstall": remove ngircd.conf if not modified Now "make uninstall" removes the installed "ngircd.conf" file, if it is still equal to our "sample-ngircd.conf" file and therefore hasn't been modified by the user. If it has been modified, it isn't removed and a notice is displayed to the user. In addition, "make install" now displays a message when no ngircd.conf file exists and the "sample-ngircd.conf" file will be installed as a starting point.

Add doc/Contributing.txt to distribution archive

Include all build-system files into distribution archives

Don't check type.h availability, it is required

Introduce numeric RPL_HOSTHIDDEN_MSG(396) This numeric is sent to the client each time it changes its displayed hostname using "MODE +/-x", and if "CloakHost" is set right after the MOTD has been sent.

contrib/ngircd.service: systemd service file for ngircd Thanks to Kyle Keen : Date: Sat, 18 Aug 2012 08:28:22 -0400 Message-ID: From: keenerd To: ngircd-ml@ngircd.barton.de Subject: [ngIRCd-ML] systemd service Hello all. Linked is a service file for ngircd. Please add this to your source tree so other people don't have to learn to write service files ;-) https://projects.archlinux.org/svntogit/community.git/plain/trunk/ngircd.service?h=packages/ngircd -Kyle Keen Arch Linux TU http://kmkeen.com

Loose GNU autoconf / automake requirements a bit Now ngIRCd requires at least GNU autoconf 2.61 and automake 1.10, the requirements of commit 67e882d4 have been too restrictive: 19.2 67e882d4 now ---------- --------- --------- --------- autoconf >=2.50 >=2.67 >=2.61 automake >=1.6 >=1.11 >=1.10 The tools required now are supported by Debian GNU/Linux 4.0 "Etch", RedHat Enterprise Linux 5, and Mac OS X 10.6.x for example. I read the changelogs of autoconf and automake, and I think ther's nothing that prevents it from working with these older versions; and we don't want to force users to upgrade without real benefits. Please note: the recommended versions are still autoconf 1.11.x and the most recent autoconf release that works with automake 1.11.x!

Change build system to support new and old GNU automake Starting with GNU automake 1.12, the "de-ANSI-fication support" has been removed, which ngIRCd used to enable building itself on very old systems. Now the problem is, that using automake >= 1.12 isn't working because of the now unsupported M4 macros. Therefore the solution that this patch implements is to dynamically generate the automake input files with our own ./autogen.sh script: configure.ng => configure.in Makefile.ng => Makefile.am This is quite an ugly approach, but it works and enables us to: 1. use current automake >= 1.12 for development and "private builds", 2. still build distribution archives using automake 1.11.x that have "de-ANSI-fication support" enabled in the generated Makefile's. And if you are using Makefile's generated with a automake version newer than 1.11.x (without "de-ANSI-fication support"), the ./configure script warns you not to use this generated build system to generate distribution archives. Drawback of this patch: you MUST use our autogen.sh script, you can't call the autoconf/automake commands directly any more; but autoreconf should still work ...

configure.in: Use AC_CONFIG_FILES macro

Always cloak client hostname, if needed Not only cloak the hostname in Client_MaskCloaked(), but also in Client_HostnameCloaked() -- so move the actual cloaking to this function and call it in Client_MaskCloaked() to get the (cloaked) hostname. This fixes USERHOST not displaying the correctly cloaked hostname, for example.

ngt_RandomStr(): Add implicit cast to "unsigned". This fixes the following warning of Xcode 4.5: src/tool/tool.c:150:19: Implicit conversion loses integer precision: 'long' to 'unsigned int'

Merge branch 'bug92-xop' By Alexander Barton (5) and Sebastian Köhler (2) * bug92-xop: Fix NAMES/WHO response when client has multi-prefix Fix prefix of "halfop" when "multi-prefix" is active Clean up doc/.gitignore doc/Modes.txt: add version number to new channel modes Fix some "whitespace glitches" Tests and documentation for xop Implemented xop support Conflicts (because of "multi-prefix fix"): src/ngircd/irc-info.c This fixes bug #92 "ngircd does not support XOP usermodes".

configure.in: Don't use AC_C_PROTOTYPES Don't use AC_C_PROTOTYPES, AM_C_PROTOTYPES is already used.

NoticeAuth: make sure messages are flushed immediately

Fix a buffer overflow when initializing the random salt for "+x" This "off by one" buffer overflow has been introduced in commit 49385a98, "Implemented hashed cloaked hostnames for +x".

Fix NAMES/WHO response when client has multi-prefix This has been fixed by commit 16f94546 "Fix NAMES response when client has multi-prefix" in the master branch, fix it in this patch series, too.

Free all listen ports on initialization Now you can reconfigure listen ports and reload the server configuration on runtime. Without this patch, no ports could be removed.

configure.in: Update checks for required and optional features Update checks for required and optional header files, data types, and functions.

Merge branch 'umode-B' This patch series allows ngIRCd to support the user mode "B" ("Bot flasg"): it is settable and unsettable by every (non-restricted) client. According to DNS777, this is how Unreal and InspIRCd do behave, so do we :-) By Alexander Barton (1) and DNS777 (1) * umode-B: Add new user mode "B" to doc/Modes.txt Implement an Unreal-like user mode "B" ("Bot mode")

configure.in: Use AC_CONFIG_HEADER instead of AM_CONFIG_HEADER AM_CONFIG_HEADER is marked obsolete and will be removed in Automake 1.13.

Fix prefix of "halfop" when "multi-prefix" is active

Initialize SSL when needed only, and disable SSL on errors With this patch, the SSL subsystem will only be initialized if at least one SSL ports is configured; so you won't get "SSL initialization failed" messages if you didn't configured it at all. And if SSL initialization fails, no SSL listen ports will be enabled later which never could establish a working SSL connection at all ...

configure.in: require autoconf 2.67 and automake 1.11 And use newer features such as bug reporting address and project URL.

Merge branch 'recognize-umode-R' By Alexander Barton (1) and DNS777 (1) * recognize-umode-R: Only allow IRC services to modify user mode "R" Recognize user mode "R"

Add new user mode "B" to doc/Modes.txt

Fix compiler warning when not building with ZLIB support This fixes: irc.c: In function ‘Option_String’: irc.c:333:9: error: variable ‘options’ set but not used

Clean up doc/.gitignore

configure.in: sort some lists (templates, output, ...)

Only allow IRC services to modify user mode "R"

ngt_RandomStr(): : make it buildable with pre-ANSI C compilers

Implement an Unreal-like user mode "B" ("Bot mode")

Update NEWS and ChangeLog files for hashed cloaked hostnames

doc/Modes.txt: add version number to new channel modes

Get_CAP_String(): make it buildable with pre-ANSI C compilers

Recognize user mode "R" This allows users to unset the user mode "R".

Hashed hostnames for CloakHost Implemented support for hashed hostnames for CloakHost. The admin can use '%x' in both the CloakHost and CloakHostModeX setting. The config option CloakHostModeX was renamed to CloakHostSalt. This salt is used for both cloaking options.

Fix some "whitespace glitches" Some have been introduced by commit 7b01bb83, some are older.

Enhance "NOTICE AUTH": show hostname and IDENT reply

Implemented hashed cloaked hostnames for +x CloakHostModeX can now contain '%x'. It will be replace by the hash of the original client hostname. The new config option CloakHostModeXSalt defines the salt for the hash function. When CloakHostModeXSalt is not set a random salt will be generated after each server restart. Spelling fix in defines.h

Merge branch 'xop' of https://github.com/kart0ffelsack/ngircd into bug92-xop * 'xop' of https://github.com/kart0ffelsack/ngircd: Tests and documentation for xop Implemented xop support Conflicts (because of merge of the 'cmode-M' branch): src/ngircd/channel.c src/ngircd/defines.h src/ngircd/messages.h

Merge branch 'cmode-M' By Alexander Barton (2) and DNS777 (1) * cmode-M: Add new channel mode "M" to doc/Modes.txt Remove Can_Send_To_Channel_Identified() Implement channel mode "M"

ngIRCd release 19.2

Add new channel mode "M" to doc/Modes.txt

Tests and documentation for xop

doc/Capabilities.txt: document "multi-prefix" capability

Remove Can_Send_To_Channel_Identified() Move the functionality directly into Can_Send_To_Channel() function. There should be no functional change ...

Implemented xop support 3 new channel user modes have been added. Half Op: +h(Prefix: %) can set the channel modes +imntvIbek and kick all +v and normal users. Admin: +a(Prefix: &) can set channel modes +imntvIbekoRsz and kick all +o, +h, +v and normal users. Owner: +q(Prefix: ~) can set channel modes +imntvIbekoRsz and kick all +a, +o, +h, +v and normal users

ngIRCd release 19.2~rc1

Implement channel mode "M" Only the server, identified users and IRC operators are able to talk.

Merge branch 'bug124-CloakHostModeX' * bug124-CloakHostModeX: Describe "CloakHostModeX" in sample-ngircd.conf an ngircd.conf(5) Rename "CloakModeHost" option to "CloakHostModeX" Introduce new configuration option "CloakModeHost" This closes bug #124.

Update ChangeLog and NEWS files

Describe "CloakHostModeX" in sample-ngircd.conf an ngircd.conf(5)

Rename "CloakModeHost" option to "CloakHostModeX"

Correctly handle asynchronously re-established server links Don't try to establish an outgoing server link after DNS lookup when this server re-connected on its own in the meantime. In addition, log a warning message if we try to update the connection index of an already connected server structure -- and ignore it. Up to now, both behaviour could lead to a race when the remote server connects to this daemon while it still prepares the outgoing connection: - The local server prepares the new outgoing connection ... - in the meantime the remote server becomes connected and registered. - Now the new outgoing connection overwrites the (correct) socket handle, - then the 2nd connection becomes disconnected: "already registered", - and the 1st connection becomes unhandled ("gets lost") because the configuration structure is reset because of the wrong socket handle. This patch hopefully fixes all these problems.

Introduce new configuration option "CloakModeHost" This closes bug #124.

Log a debug message when SIGUSR2 is handled

doc/Platforms.txt: more updates Added: - armv6l/unkn./linux-gnueabi, gcc 4.4.5 - i686/pc/linux-gnu, gcc 2.7.2 Updated: - i386/pc/solaris2.11, gcc 4.2.3 Thanks to Götz Hoffart!

NoticeAuth: Fix test if IDENT reply has been invalid This fixes conn.c: In function ‘cb_Read_Resolver_Result’: conn.c:2252: warning: comparison between pointer and integer

IDENT reply: only allow alphanumeric characters in user name Only alphanumeric characters are allowed in the user name, so ignore all IDENT replies that would violate this rule and use the one supplied by the USER command.

USER command: only allow alphanumeric characters in user name Only alphanumeric characters are allowed in the user name, so terminate the connection if any "strage" characters have been supplied by the user. This is how other IRC daemons (like ircd2.11 and ircd-seven) behave ...

doc/Platforms.txt: add powerpc/apple/darwin7.9.0

Change wording of "TLS initialized" message Don't use the word "socket" to identify the connection number, but use the word "connection" like on all the other messages logged.

Pidfile_Create(): Don't leak file descriptor on error path Detected by cppcheck: [src/ngircd/ngircd.c:502]: (error) Resource leak: pidfd

INSTALL: Add "satisfy prerequisites" section Include information for RedHat/Fedora and Debian/Ubuntu based Linux distributions.

NEWS, ChangeLog: fixed some misspellings

Numeric 005 (ISUPPORT), CHANMODES: add missing mode "r"

doc/Platforms.txt: add "armv7l/unknown/linux-gnueabi"

Add instructions for setting up Atheme.

irc-cap.c: mark arguments of Handle_CAP_ACK() as "unused" This fixes irc-cap.c: In function ‘Handle_CAP_ACK’: irc-cap.c:163: warning: unused parameter ‘Client’ irc-cap.c:163: warning: unused parameter ‘Arg’

irc-login.c, login.c: add missing include of "string.h" This fixes the following warnings with GCC 4.4.5 on Linux: irc-login.c: In function ‘IRC_PASS’: irc-login.c:92: warning: implicit declaration of function ‘strlen’ irc-login.c:92: warning: incompatible implicit declaration of built-in function ‘strlen’ irc-login.c:113: warning: incompatible implicit declaration of built-in function ‘strlen’ irc-login.c:129: warning: implicit declaration of function ‘strchr’ irc-login.c:129: warning: incompatible implicit declaration of built-in function ‘strchr’ irc-login.c:133: warning: implicit declaration of function ‘strcmp’ irc-login.c: In function ‘IRC_SERVICE’: irc-login.c:556: warning: incompatible implicit declaration of built-in function ‘strchr’ login.c: In function ‘Login_User’: login.c:131: warning: implicit declaration of function ‘strcmp’

doc/Modes.txt: Document missing channel mode "e"

Merge branch 'master' of /srv/git/ngircd * 'master' of /srv/git/ngircd: "multi-prefix" capability 2/2: adjust NAME and WHO handlers "multi-prefix" capability 1/2: implement complete CAP infrastructure IRC_Send_NAMES(): Code cleanup New function Client_CapSet() in addition to Client_Cap{Add|Del} "CAP REQ" starts capability negotiation and delays user registration Xcode: update project file for Xcode 4.3 Correctly handle "CAP END", new client type CLIENT_WAITCAPEND Implement core IRC capability handling and "CAP" command New "login" source file Introduce_Client() => Client_Introduce(), and move it to client.c

contrib/platformtest.sh: support "CC=xxx MAKE=yyy ./platformtest.sh" Now you can use contrib/platformtest.sh on platforms that require a "special" make (not "make") or compiler (not cc/gcc) binary.

Merge branch 'capabilities' * capabilities: "multi-prefix" capability 2/2: adjust NAME and WHO handlers "multi-prefix" capability 1/2: implement complete CAP infrastructure IRC_Send_NAMES(): Code cleanup New function Client_CapSet() in addition to Client_Cap{Add|Del} "CAP REQ" starts capability negotiation and delays user registration Correctly handle "CAP END", new client type CLIENT_WAITCAPEND Implement core IRC capability handling and "CAP" command New "login" source file Introduce_Client() => Client_Introduce(), and move it to client.c

"multi-prefix" capability 2/2: adjust NAME and WHO handlers The NAME and WHO commands now return multiple usermode prfixes when the "multi-prefix" capability is in effect for the requesting client. See

Xcode: update project file for Xcode 4.3 (No changes needed)

platformtest.sh: Detect Open64 C compiler

"multi-prefix" capability 1/2: implement complete CAP infrastructure Now ngIRCd is able to handle "CAP LS", "CAP REQ", "CAP LIST", and "CAP CLEAR" commands. "multi-prefix" can be set/unset, but has no functionality - yet!

Fix 8ec17063: "Lists_Add(): use size of destination when copying data" Thanks to Florian Westphal for spotting my silliness ...

IRC_Send_NAMES(): Code cleanup

Xcode: correctly sort conn-ssl.{c|h} files in file list

New function Client_CapSet() in addition to Client_Cap{Add|Del}

Lists_Add(): use size of destination when copying data This fixes the following warning of clang: /src/ngircd/lists.c:152:44: warning: size argument in 'strlcpy' call appears to be size of the source; expected the size of the destination [-Wstrlcpy-strlcat-size] But it isn't a real problem, because the size of the source always is the same than the size of the destination ...

"CAP REQ" starts capability negotiation and delays user registration New helper function Set_CAP_Negotiation().

Makefiles: list each source files on a separate line Patches that add/remove source files become much nicer this way :-)

Correctly handle "CAP END", new client type CLIENT_WAITCAPEND

Add missing documentation files to Xcode project

Implement core IRC capability handling and "CAP" command This patch implements the core functions to support "IRC Capabilities" and the IRC "CAP" command as used by other servers and specified here: . It enables ngIRCd to support the defined handshake, but it doesn't implement any capabilities, so "CAP LS" and "CAP LIST" always return the empty set and "CAP REQ ..." always fails with "CAP NAK".

Don't ignore "permission denied" errors when enabling chroot Up to now, ngIRCd silently ignored permission denied errors when trying to enable a chroot setup: only the "not running chrooted" message became logged later on. This patch lets ngIRCd exit with a fatal error when the chroot can't be enabled on startup -- this is the much safer bevahiour!

New "login" source file Rename Hello_User[_PostAuth] to Login_User[_PostAuth] and move it to the new login.c; and move cb_Read_Auth_Result(), too. This will enable further code to easily call Login_User() when required.

FAQ: enhance description of chroot setup

Introduce_Client() => Client_Introduce(), and move it to client.c

ngIRCd Release 19.1

Update ChangeLog for upcoming ngIRCd 19.1 release

Fix gcc warning, initialize "list" variable to NULL This fixes the following warning with gcc 4.6.3.: irc-mode.c: In function "Channel_Mode": irc-mode.c:947:26: error: "list" may be used uninitialized in this function irc-mode.c:884:25: error: "list" may be used uninitialized in this function (The variable has never been used uninitialized, so don't worry)

Fix manual page "hyphen-used-as-minus-sign" error (lintian) Thanks to Christoph Biedl for reporting this!

Fix typo: Please not -> Please note Thanks to Götz Hoffart!

Fix typo: recieved -> received Thanks to Christoph Biedl.

Update NEWS and ChangeLog files

Really include _all_ patches to build the Anope module

getpid.sh: Fix testcase error for Debian using sbuild When * building the ngircd Debian package (on Linux at least) and * using the sbuild build system, the command "ps -af" does not include the commands running inside the sbuild system. Therefore, start-server.sh will report a fail as getpid.sh cannot not find the ./T-ngircd1 just started although it's actually running. This results in a funny build log ... starting server 1 ... failure! FAIL: start-server1 running connect-test ... ok. PASS: connect-test The self-test of getpid.sh however will likely succeed as it's happy if it sees any process with "sh" somewhere in the name. Things go downhill from there. The confusing things are: * The alternative cowbuilder/pbuilder does not have this problem. * The alternative usage "ps ax" does fine. So, as a quick hack, the patch attached adds another switch to getpid.sh.

Don't log "ngIRCd hello message" two times Start "regular" logging not until the configuration file has been read in and "SyslolgFacility" is set, and log all configuration errors using the generic "daemon" facility. So if there are no configuration errors, logging starts right after parsing the configuration and we log the configuration file used _after_ reading it. But this is no problem because every configuration error message includes the configuration file name as well. (The "double hello" has been introduced by commit 3641e5110952)

ngIRCd release 19

Merge branch 'master' of /srv/git/ngircd * 'master' of /srv/git/ngircd: Update doc/Platforms.txt for ngIRCd 19 doc/README-Interix.txt: note that GNU make should be used

Update doc/Platforms.txt for ngIRCd 19

Update config.guess and config.sub to recent versions

doc/README-Interix.txt: note that GNU make should be used

Don't accept "[SSL]" in config when no SSL support is built in

Fix C syntax: duplicate ";;" should be ";" Using gcc 2.7.2, this fixes: irc-channel.c: In function `join_allowed': irc-channel.c:86: parse error before `const'

Correctly re-open syslog logging after reading of configuration Syslog logging has been initialized before reading the configuraton file, so ngIRCd always used the default facility and ignored the "SyslogFacility" configuration option. Thanks to Patrik Schindler for reporting this issue!

Logging: remove "Activating ..." info message

ngIRCd release 19~rc1

Update RPM spec file description to match Debian "control file"

Update NEWS and ChangeLog files

Fix forwarding of LIST commands Bug reported by Cahata, thanks!

Update preliminary ngIRCd protocol module for Anope 1.9.6

New_Connection(): don't set the client hostname twice Setting the hostname twice doesn't do much harm a lot, but isn't elegant. And for IPv6 addresses, it isn't correct the first time (missing []) ...

Client_SetHostname(): Code cleanup, more debug logging

io: use define for number of possible events

io: remove outer do {} while loops for epoll/kqueue/devpoll backends simplifies things a bit. io_dispatch() is called repeatedly from the main loop.

Enhance server command limits This patch updates the limits for handling commands from a remote server: - " / 5 + " using "=10" during normal operation, - the above count multiplied with 5 while servers are syncing. The intention is to a) make the limit dependent of the number of users in the network (the more users, the more commands required to sync) and b) to significantly rise this limit while servers are joining the network to make the login and synchronization faster.

Send a PING at the end of the server sync to detect it At the end of sending all "state" to the remote server, a PING command is sent to request a PONG reply. Until then, no "regual" PING was sent, so Conn_LastPing() is null and now becomes non-null in the PONG command handler. So the servers are still synchronizing when Conn_LastPing() is 0, which could easily be tested.

New function Conn_UpdatePing() to update the "ping timestamp"

Conn_UpdateIdle(): Code cleanup

RPL_ISUPPORT_MSG(005): add "EXCEPTS=e INVEX=I" Thanks to Cahata for the idea!

Fix "MAXLIST=beI:50": the limit is the sum of all lists "Modes which are specified in the same pair share the same maximum size", so "beI:50" means a total of 50 entries, regardless of the list. See , thanks to Cahata for reporting this!

Update NEWS and ChangeLog files

New RPL_WHOISHOST_MSG(378): show hostname and IP address The numeric RPL_WHOISHOST_MSG(378) returns the DNS hostname (if available) and the IP address of a client in the WHOIS reply. Only the user itself and local IRC operators get this numeric.

New function Conn_GetIPAInfo(): get IP address of a connection

G/K-Lines: only add and delete valid IRC masks

Check G/K-Lines before the client has been registered, too This allows to use "*!@" or "*!*@" masks to reject clients even before receiving PASS, NICK and USER commands and before forking authentication child processes which reduces resource usage.

Streamline handling of connection rejects (bad password, G/K-line) - Use Client_Reject(), get rid of Reject_Client(). - Refactor Class_IsMember() to Class_GetMemberReason(), - New function Class_HandleServerBans().

New function Client_Reject() to reject clients on connect

New function Lists_CheckReason() to get reason of list entries

Update NEWS and ChangeLog files

Fix ERR_{SUMMON|USERS}DISABLED: don't repeat command name in reply

Implement channel exception list (mode 'e') This allows a channel operator to define exception masks that allow users to join the channel even when a "ban" would match and prevent them from joining: the exception list (e) overrides the ban list (b).

{Add|Del}_Ban_Invite > {Add_To|Del_From}_List(): more generic

Rename ShowInvitesBans() to ShowChannelList(), make it more flexible

PRIVMSG/NOTICE: handle nick!user@host masks case-insensitive And enhance our test suite to check this a little bit better :-)

PRIVMSG/NOTICE: don't stop list processing on invalid target Process further targets, even if one has been a server ID: just skip this one with an error message and continue.

Implement user mode 'C': require "same channel" to send message If the target user of a PRIVMSG or NOTICE command has the user mode 'C' set, it is required that both sender and receiver are on the same channel. This prevents private flooding by completely unknown clients.

New RPL_WHOISREGNICK_MSG(307) numeric: indicate if nick is registered

IRC_WHOIS_SendReply(): Code cleanup

Limit channel invite and ban lists to 50 entries - New function Lists_Count(). - New limit #define MAX_HNDL_CHANNEL_LISTS = 50. - New numeric #define ERR_LISTFULL_MSG(478). - Adjust numeric RPL_ISUPPORT2_MSG(005) accordingly ("MAXLIST")

Make Send_ListChange() a little bit more generic

Remove unused prototype of Lists_AlreadyRegistered() This prototype has been introduced by commit fa7bb279 in 2006, but as far as I can see, this function never existed ...

Channel lists: Fix duplicate check and error messages - Check correct list for duplicates when adding items. - Don't generate any messages when adding duplicates or removing non-existing items (this is how ircd-seven and ircu behave). - Code cleanup: Add_Ban_Invite(), Del_Ban_Invite().

Don't enforce MAX_HNDL_MODES_ARG on server and service links

Update documentation (fix some URL, update some info)

Update NEWS and ChangeLog for next ngIRCd release once more

Don't stop join handling on faulty channel, skip it (part #2) Commit 565523cb allowed processing of further channel names given to the JOIN command when a single name was invalid. After this patch, the JOIN command handler continues to process channel name lists even after errors like "channel is full", "too many channels", and the like and generates appropriate error messages for all the channels given by the client.

JOIN command: don't check channel limit if already member Don't check the channel limit and don't report "too many channels" when trying to join a channel that the client is already a member of.

Return ERR_UNKNOWNMODE(472) for unknown channel modes The daemon reported ERR_UMODEUNKNOWNFLAG(501), which is wrong.

Numberic 005 (ISUPPORT), CHANMODES: add "O", "R", "z" modes

Limit list replies of LIST, WHO, WHOIS, and MAX_RPL_WHOWAS Introduce new #define's MAX_RPL_LIST(100), MAX_RPL_WHO(25), MAX_RPL_WHOIS(10), and MAX_RPL_WHOWAS(25).

New function IRC_CheckListTooBig() to check size of list replies It the limit is reached, a NOTICE is sent to the client and list processing should stop.

LIST command: compare pattern case insensitive

IRC_LIST(): Code cleanup

DEFAULT_WHOWAS->DEF_RPL_WHOWAS; MAX_CMODES_ARG->MAX_HNDL_MODES_ARG To streamline naming, in preparation for MAX_RPL_WHO and MAX_RPL_WHOWAS :-)

defines.h: Code cleanup and (a little bit) more documentation

RPL_ISUPPORT (numeric 005): Report MODES= "Maximum number of channel modes with parameter allowed per MODE command." See for details.

Channel modes: really break handling when MAX_CMODES_ARG is hit This fixes 98493077.

channel modes: only handle MAX_CMODES_ARG modes with arguments Limit the MODE command to handle a maximum of MAX_CMODES_ARG (5) channel modes that require an argument (+Ibkl) per call. Please note: Further modes that require arguments are silently ignored and end the handling of any further modes. This is similar to the behavior of ircd2.11 (silently ignores but seems to handle other modes) as well as ircd-seven (silently ignores but handles some(!) other modes) ...

Fix handling of channel mode sequence with/without arguments For example, don't generate wrong error messages when handling "MODE #chan +IIIIItn *!aa@b *!bb@c *!cc@d *!dd@e *!ee@f".

Conn_Write(): Make sure there is a client when detecting its type The assert(client != NULL) got triggered during our tests, so there is an error path that resulted in the connection being still established (sock >= 0) but the client structure already freed. So Conn_Write() should handle it!

Proc_Close(): Only close socket if it is still valid It could be invalid when calling Proc_Close() a 2nd time, for exmaple, which could happen when we hit a timeout doing IDENT requests :-(

WHOIS command: make sure matching is case-insensitive And make sure that RPL_ENDOFWHOIS replies with the unmodified mask like it has been received from the client.

WHOIS command: don't anser queries for IRC servers Thanks to Cahata for spotting this!

WHOIS command: make sure the reply ends with RPL_ENDOFWHOIS Up to now, each reply for itself ended in RPL_ENDOFWHOIS and queries for unknown nick names lacked the RPL_ENDOFWHOIS -- both is wrong.

README: update features list, borrow from list on our website

LINKS command: support parameter The can be used to limit the servers shown in the listing.

IRC_LINKS(): Code cleanup; more documentation

Add 1 second penalty for every further target on PRIVMSG/NOTICE This reduces the possibility of flooding channels with commands like "PRIVMSG/NOTICE #a,#n,#c,... :message" a little bit. Problem noticed by Cahata -- thanks!

Conn_SetPenalty(): Add new "penalty time" on each function call Until now, the penalty time has only been set when longer as the already set one, so it didn't accumulate. And add documentation for and clean up code in Conn_SetPenalty() and Conn_ResetPenalty() functions.

Enhance log messages when setting user and group

NGIRCd_getNobodyID(): Code cleanup

Display correct error message when "Server{UID|GID}" is invalid This partly closes bug #118. ngIRCd still starts up even when Server{UID|GID} is invalid: then the daemon falls back to "nobody" when running with root(0) privileges (as before).

NGIRCd_Init(): Code cleanup

main(): Code cleanup

README: point to included COPYING file, not gnu.org

Update Copyright notices for 2012

lists: don't crash if reason ptr is NULL commit 15fec92ed75c3de0b32c40d005e93e3f61aef77e (Update list item, if it already exists) can make ngircd crash because 'Reason' can be NULL, as reported by Cahata on the ngircd mailing list. Doesn't affect any released ngircd versions. Also, make sure that we do not pass NULL as arguments to a '%s' printf-like function.

Don't stop join handling on faulty channel, skip it When JOIN is received with more than one channel name, don't stop processing on the first error (e.g. bad name, wrong channel key, ...) but report an error and continue with the other given channel names. Reported by Cahata -- thanks!

IRC_JOIN(): Code cleanup

ISON command: reply with correct upper-/lowercase nick names Reported by Cahata -- thanks!

IRC_ISON(): Code cleanup

Remove unused "bool have_arg" from IRC_WHO() This fixes: irc-info.c: In function ‘IRC_WHO’: irc-info:936:18: warning: variable ‘have_arg’ set but not used

Update NEWS and ChangeLog for next ngIRCd release

ngircd.conf.5: reword description of "Ports" variable

New configuration option "PAMIsOptional" When "PAMIsOptional" is set, clients not sending a password are still allowed to connect: they won't become "identified" and keep the "~" character prepended to their supplied user name.

PAM: don't use global password buffer for conv struct Use the pointer of the password of the client directly. Eventually we can get rid of the global password again ...

doc/Modes.txt: document channel mode "r" And make clear, that user mode "r" and channel mode "r" are not set by ngIRCd itself but by IRC services.

Fixed handling of WHO commands This fixes two bugs: - "WHO " returned nothing at all if the user was "+i" (reported by Cahata, thanks). - "WHO " returned channel names instead of "*" when the user was member of a (visible) channel. Clean up code and add documentation as well.

Remove unused "time_t now" from Lists_Check() This fixes: lists.c: In function ‘Lists_Check’: lists.c:330:9: warning: variable ‘now’ set but not used

Fixed some spelling errors in documentation and code comments Thanks to Christoph Biedl!

contrib/Debian/control: Update and complete "Build-Depends"

Update our Debian package descriptions with "official" ones See Debian Bug #648241 for details.

Fixed typo in two error messages Thanks to Christoph Biedl!

LUSERS reply: only count "visible" channels Rename Channel_Count() to Channel_CountVisible() and only count channels that are visible to the requesting client, so the existence of secret channels is no longer revealed by using LUSERS. Reported by Cahata -- thanks!

IRC_Send_LUSERS(): Code cleanup

Don't stop mode handling on unknown modes; skip it Unknown user and channel modes no longer stop the mode parser, but are simply ignored. Therefore modes after the unknown one are now handled. This is how ircd2.10/ircd2.11/ircd-seven behave, at least. Reported by Cahata -- thanks!

IRC_xLINE(): output an error message for unexpected "lines" This fixes: irc-oper.c: In function ‘IRC_xLINE’: irc-oper.c:429: warning: ‘class’ may be used uninitialized in this function irc-oper.c:430: warning: ‘class_c’ may be used uninitialized in this function

README: Update list of implemented commands

Update list item, if it already exists This updates the "validity" (timeout) as well as the "reason" text, if given.

Lists_CheckDupeMask(): return pointer to already existing item The old behavior of returning true/false is compatible to this change, so there are no other code changes required.

Log better error messages when rejecting clients

Synchronize G-Lines on server login

Op_Check(): always accept commands from a remote server itself

Class_GetList() now retuns a pointer to list_head structure

Check G-Line and K-Line lists after authenticating clients

New functions Lists_Expire() and Class_Expire() GLINE and KLINE lists are cleared automatically now, not when they are checked. So "STATS g" and "STATS k" no longer show expired entries :-)

Implement IRC_xLINE(): handler for "GLINE" and "KLINE" commands

Op_Check(): return client that initiated the request or NULL The old behavior of returning true/false is compatible to this change, so there are no other code changes required.

irc-oper.c: code cleanup; more documentation

Implement IRC "STATS g" and "STATS k" command

New function Class_GetList()

lists.{c|h}: code cleanup; more documentation

List and class handling: add optional "reason" text Adjust Lists_Add() and Class_AddMask() accordingly, implement Lists_GetReason() and Lists_GetValidity().

Add new class.{c|h} module to Xcode project

Add new class.{c|h} to project Implement Class_{AddMask|DeleteMask|IsMember}() functions.

Lists: change "only once" property into "valid until" The old "only once" true/false behavior is still supported, so there are no other code changes required.

Xcode: update project file for Xcode 4.2

define HAVE_GAI_STRERROR for Mac OS X Xcode builds On Mac OS X 10.7 Lion, this fixes In file included from .../contrib/MacOSX/../../src/ngircd/client.c:28: /Developer/SDKs/MacOSX10.7.sdk/usr/include/netdb.h:272:13: error: expected identifier or '('

Configuration: get rid of Conf_Oper_Count and Conf_Channel_Count Count elements dynamically when needed.

./configure: Fix logic and quoting of poll() detection code This fixes commit 8e193df ...

Suppress 'Can't create pre-defined channel: invalid name: ""' messages Skip predefined channel structures that have configured no name, like the "--configtest" does.

Only use poll() when poll.h exists as well

Not only check for poll(), make sure poll.h exists as well This fixes building ngIRCd on Debian GNU/Linux 1.3 "Bo" :-)

whois-test: handle local hostname = "localhost.localdomain" Use the pattern "localhost*" for valid local hostnames.

sample-ngircd.conf: show correct default for "PAM" variable The default of "PAM" is "yes" when ngIRCd has been configured to use it, so show the correct default value in the sample configuration file. Closes #119.

Update GPL 2 license text to current version See .

Test for gai_strerror() If gai_strerror() isn't available, use a macro that simply returns a static error message (regardless of the real error code). For example, GNU libc 2.0.7 doesn't implement gai_strerror().

Only use AI_NUMERICHOST if it is #define'd It isn't using GNU libc 2.0.7, for example ...

defines.h: fix comment: "lenth" -> "length" Reported by Christoph Biedl in #ngircd. Thanks!

Init_Server_Struct(): correctly zero Server->bind_addr Don't use the size of the pointer, use the size of the variable!

Clean up and fix comments of Check_ArgIsTrue() Thanks to kaFux for pointing this out! And fix code formatting as well ...

Update doc/GIT.txt

Only close "unrelated" sockets in forked child processes This fixes the problem that ngIRCd can't do any IDENT lookups because of the socket has already been closed in the child process. The bug has been introduced starting with ngIRCd 17 ... :-( (commit ID 6ebb31ab35e)

Added doc/Modes.txt: document modes supported by ngIRCd

Implemented user mode "R" and channel mode "R" - User mode "R": indicates that the nick name of this user is "registered". This mode isn't handled by ngIRCd itself, but must be set and unset by IRC services like Anope. - Channel mode "R": only registered users (having the user mode "R" set) are allowed to join this channel.

Use Proc_Close() to remove no longer unused pipes to child processes This removes spurious (but harmless) debug messages.

New function Proc_Close() to shutdown pipes to child processes

Introduce DEBUG_BUFFER, rework some debug messages DEBUG_BUFFER is off by default and therefore disables these messages: - "Handle_Write() called for connection XX, YY bytes pending ..." - "Connection XX: ZZ bytes left in read buffer."

Testsuite: bind to loopback (127.0.0.1) interface only

doc/Platforms.txt: ngIRCd 18 on Nexenta works Thanks to Götz Hoffart for testing!

New 2nd message "Nickname too long" for error code 432

Client_CheckNick(), Client_IsValidNick(): code cleanup

Merge branch 'ServerMode' * ServerMode: Handle channel user modes 'a', 'h', and 'q' from remote servers Handle unknown channel modes on server links Handle unknown user modes on server links IRC_MODE(), Client_Mode(): code cleanup [2/2] Enlarge client user mode buffer, reduce client flags buffer Infom clients when other servers change their user modes IRC_MODE(), Client_Mode(): code cleanup [1/2]

Merge branch 'bug113-SrvPrefix' * bug113-SrvPrefix: Slightly change (and document!) IRC_KILL() calling convention Spoofed prefixes: close connection on non-server links only

Handle channel user modes 'a', 'h', and 'q' from remote servers These channel user modes aren't used for anything at the moment, but ngIRCd knows that these three modes are "channel user modes" and not "channel modes", that is that these modes take an "nick name" argument. Like unknown user and channel modes, these modes are saved and forwarded, but ignored otherwise.

Xcode: update project file to Xcode 3.2 or newer Xcode requires Mac OS X 10.6 or newer; Xcode 4 supports this project format as well, so effectively you can use Mac OS X 10.6.x or 10.7.x for building ngIRCd with the Apple Xcode IDE.

Handle unknown channel modes on server links

Slightly change (and document!) IRC_KILL() calling convention

Xcode: Mac OS X config.h: support 10.5 as well as 10.6/10.7 SDK

Handle unknown user modes on server links

Spoofed prefixes: close connection on non-server links only On server-links, spoofed prefixes can happen because of the asynchronous nature of the IRC protocol. So don't break server-links, only log a message and ignore the command. This fixes bug 113, see:

Xcode: exclude more Xcode 4 specific directories in ".gitignore"

IRC_MODE(), Client_Mode(): code cleanup [2/2]

Fix typo in doc/Platforms.txt; make Linux footnote more generic

Cast getpid() and time() results for srand() input This fixes: src/ngircd/ngircd.c:596: warning: implicit conversion shortens 64-bit value into a 32-bit value (i686-apple-darwin11-llvm-gcc-4.2)

Enlarge client user mode buffer, reduce client flags buffer We have to enlage our user mode buffer, so we can handle even unknown user modes in the future; and reduce the client flags buffer, because I can't imagine why we ever would need ~100 flags!? Now we support up to 15 user modes (was: 8) and up to 15 flags (was: 99). So in the end, we even save 99-15+8-15=77 bytes for each client structure!

ngIRCd release 18

Xcode: update and add missing files to project

Infom clients when other servers change their user modes

Update ChangeLog and NEWS for ngIRCd release 18

IRC_QUIT(): disconnect directly linked servers sending QUIT Without this patch, the server becomes removed from the network and the client structures, but the connection isn't shut down at all ...

IRC_MODE(), Client_Mode(): code cleanup [1/2]

Updated doc/Platforms.txt for ngIRCd release 18

contrib/ngindent: detect "gindent" as GNU indent

Testsuite: make getpid.sh work even when run as root Use ps(1) flag "-a" (as well as "-f"): "Select all processes except both session leaders (see getsid(2)) and processes not associated with a terminal." Thanks to Götz Hoffart for reporting this problem!

MorePrivacy: Don't register WHOWAS information Citing an email from Florian to the ngIRCd mailing list: "I wonder what the expected behaviour is when Conf_MorePrivacy is changed from 'yes' to 'no' and the config is reloaded. At the moment, WHOWAS will start giving out information on Users that were connected during Conf_MorePrivacy=yes period. If this is not wanted, Client_RegisterWhowas() should be changed to not store a record when Conf_MorePrivacy is enabled." And I think it is "not wanted" :-)

doc/Platforms.txt: re-add mipsel/unknown/linux-gnu with gcc 4.1.2

Add preliminary ngIRCd protocol module for Anope 1.9 See contrib/Anope/README and doc/Services.txt for more details and installation instructions!

Updated doc/Platforms.txt: mipsel/unknown/linux-gnu

Update timestamp of ngircd(8) manual page

ngIRCd release 18~rc2

GnuTLS: use 1024 (DH_BITS_MIN) as minimum size of the DH prime For outgoing connections, we use 2048 (DH_BITS) since commit 49b2d0e. This patch enables ngIRCd to accept incoming connections from other servers and clients that use at least 1024 bits (and no longer requires 2048 for incoming connections, too). Patch proposed by Florian Westphal.

ngircd.8: document debugging options

ngircd.conf.5: strip "SSL" prefix from variables in [SSL] section

Fix some wording, use spellchecker ;-)

doc/SSL.txt: adopt to new configuration file layout

ngIRCd release 18~rc1

hash: Use UINT32 instead of uint32_t

Update NEWS and ChangeLog file for our upcoming next release

hash: use more recent lookup3 algorithm instead of lookup2 Bob Jenkins published a newer hash function in May 2006, it has better distribution. See http://burtleburtle.net/bob/hash/doobs.html for lengthy comparisions.

Use srand()/rand() instead of srandom()/random(); seems to be more portable

Merge branch 'MorePrivacy' * MorePrivacy: New configuration opion "MorePrivacy" to "censor" some user information

sample-ngircd.conf: remove "SSL" prefix from SSL-related variables

New configuration opion "MorePrivacy" to "censor" some user information this patch contains: * Fix for Conf_CloakUserToNick to make it conceal user details * Adds MorePrivacy-feature MorePrivacy censors some user information from being reported by the server. Signon time and idle time is censored. Part and quit messages are made to look the same. WHOWAS requests are silently dropped. All of this is useful if one wish to conceal users that access the ngircd servers from TOR or I2P.

Merge branch 'ScrubCTCP' * ScrubCTCP: Add documentation for "ScrubCTCP" configuration option New option to scrub incoming CTCP commands

INSTALL: document changed location of configuration variables

Merge branch 'newconfig' * newconfig: sample-ngircd.conf: "SyslogFacility" should be commented out Move SSL-related configuration variables to new [SSL] section CheckFileReadable(): only check when a filename is given ... PAM: make clear which "Password" config option is ignored Really remove [Features] in our manual pages INSTALL: document changed location of configuration variables Update sample config file and manual page for new config structure Testsuite: update configuration files for new config file format Display configuration errors more prominent on "--configtest" conf.c: code cleanup Check for redability of SSL-related files like for MOTD file Restructure ngIRCd configuration, introduce [Limits] and [Options]

Add documentation for "ScrubCTCP" configuration option

Update sample config file and manual page for new config structure

sample-ngircd.conf: "SyslogFacility" should be commented out

New option to scrub incoming CTCP commands This patch makes it possible to scrub incomming CTCP commands from other servers and clients alike. The ngircd oper can enable it from the config file, by adding "ScrubCTCP = yes" under [OPTIONS]. It is default off. CTCP can be used to profile IRC users (get user clients name and version, and also their IP addresses). This is not something we like to happen when user pseudonymity/secrecy is important. The server silently drops incomming CTCP requests from both other servers and from users. The server that scrubs CTCP will not forward the CTCP requests to other servers in the network either, which can spell trouble if not every oper knows about the CTCP-scrubbing. Scrubbing CTCP commands also means that it is not possible to send files between users. There is one exception to the CTCP scrubbing performed: ACTION ("/me commands") requests are not scrubbed. ACTION is not dangerous to users (unless they use OTR, which does not encrypt CTCP requests) and most users would be confused if they were just dropped. A CTCP request looks like this: ctcp_char, COMMAND, arg0, arg1, arg2, .. argN, ctcp_char ctcp_char is 0x01. (just like bold is 0x02 and color is 0x03.) They are sent as part of a message and can be delivered to channels and users alike.

Testsuite: update configuration files for new config file format

New documentation: "how to contribute"

Move SSL-related configuration variables to new [SSL] section

Display configuration errors more prominent on "--configtest"

conn: fix error handling when connecting to server The io_event_create error handling seems to miss a 'return' statement. Fix this by moving io_event_create() call around so we do not need the Conn_Close/Init calls in the error case.

CheckFileReadable(): only check when a filename is given ...

conf.c: code cleanup

ssl: gnutls: bump dh bitsize to 2048 problem is that some clients refuse to connect to severs that only offer 1024. For interoperability it would be best to just use 4096, but that takes minutes, even on current hardware.

PAM: make clear which "Password" config option is ignored

Check for redability of SSL-related files like for MOTD file Remove functions ssl_print_configvar() and ConfSSL_Puts(), introduce new function CheckFileReadable().

Mac OS X: split up make targets New targets are: "have-packagemaker", "osxpkg-dest"

Really remove [Features] in our manual pages

Restructure ngIRCd configuration, introduce [Limits] and [Options] The intention of this restructuring is to make the [Global] section much cleaner, so that it only contains variables that most installations must adjust to the local requirements. All the optional variables are moved to [Limits], for configurable limits and timers of ngIRCd, and [Options], for optional features. The old variables in the [Global] section are deprecated now, but still recognized.

fix clang warning about dead stores clang 'scan-build': Value stored to 'r' is never read Value stored to 'fd' is never read

contrib/platformtest.sh: fix gcc version detection Now the version of GNU C is detected correctly on SuSE Linux, too ...

parse: fix logical expression testing for non RFC1459 links parse.c:284: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' The expression looks dubious, this should probably be an if-not-set, then... test.

conn: avoid needlesly scary 'buffer overflow' messages When the write buffer space grows too large, ngircd has to disconnect the client to avoid wasting too much memory. ngircd logs this with a scary 'write buffer overflow' message. Change this to a more descriptive wording.

Only require server prefixes on non RFC1459 links Not all servers (and services!) using the RFC1459 protocol style send prefixes on all commands; so don't require them to do so. This relaxes the requirements introduced by commit 15775e679.

Merge branch 'master' of git://arthur.barton.de/ngircd-alex * 'master' of git://arthur.barton.de/ngircd-alex: Do reverse lookups using the AF of the incoming connection resolve: fix reverse lookups of client connections with ConnectIPv6=no

Do reverse lookups using the AF of the incoming connection This fixes errors like this one: Address mismatch: 2001:1234:abcd:1::1 != 192.168.1.1

Mac OS X: install on root volume only, and set correct permissions Update Mac OS X Installer.app description bundle, so that the ngIRCd package can only be installed on the root volume ("/"); and make sure that all installed files and directories have correct ownership and permissions.

resolve: fix reverse lookups of client connections with ConnectIPv6=no We re-use the same helper function for both forward lookups (when we want to connect to a peer server) and for validation of reverse loopups (where we make a lookup on the hostname returned by a reverse lookup on the IP address that connected). Problem: When ConnectIPv6=no, the forward lookup helper sets the adderss family to AF_INET, and, if out client connected via ipv6, we fail to validate the result. Thus move the ConnectIPvX check out of the helper.

Mac OS X: update installer texts and add logo.

Doxygen'ify conf.c

New function Config_Error_Section(); and code cleanup

Add some type casts to random() and srandom() functions This fixes two gcc warnings (on Mac OS X): "warning: implicit conversion shortens 64-bit value into a 32-bit value"

ngircd: improve rng initialisation we do not need this for cryptographic purposes, but we can do better than plain srandom(getpid()). Also, keep in mind that rng state is inherited across fork(), so re-init it in the child.

Merge branch 'AuthPing' * AuthPing: Add documentation for "RequireAuthPing" configuration option New configuration option "RequireAuthPing": PING-PONG on login

Merge branch 'NoticeAuth' * NoticeAuth: Add documentation for "NoticeAuth" configuration option Configuration: move "NoticeAuth" to GLOBAL section New configuration option "NoticeAuth": send NOTICE AUTH on connect

Add documentation for "RequireAuthPing" configuration option

ngircd.conf.5: Add variable type to "CloakHost" and "CloakUserToNick"

Add documentation for "NoticeAuth" configuration option

New configuration option "RequireAuthPing": PING-PONG on login When enabled, this configuration option lets ngIRCd send a PING with an numeric "token" to clients logging in; and it will not become registered in the network until the client responds with the correct PONG. This is used by QuakeNet for example (ircu/snircd), and looks like this: NICK nick :irc.example.net PING :1858979527 USER user . . :real name PONG 1858979527 :irc.example.net 001 nick :Welcome to the Internet Relay Network ...

Xcode: don't list sample-ngircd.conf, use sample-ngircd.conf.tmpl

Configuration: move "NoticeAuth" to GLOBAL section

Warn when unknown variables are found in [Features] section

New configuration option "NoticeAuth": send NOTICE AUTH on connect When enabling "NoticeAuth" in the [Features] section, ngircd will send "NOTICE AUTH" messages on client connect like e.g. snircd (QuakeNet) does.

Update doc/GIT.txt

Update INSTALL text

Generate WALLOPS message on SQUIT from IRC operator So SQUIT now behaves like CONNECT and DISCONNECT commands, when called by an IRC operator (and not received from an other server).

Commands received from other servers must have prefixes Make sure that all commands received from other servers do have valid prefixes. Only exceptions are PING and ERROR commands that can occure without prefixes when generated by the remote peer itself.

Allow servers to send more commands in the first 10 secods This helps to speed up server login and network synchronisation.

IRC_CHANINFO(): Code cleanup

Handle_GLOBAL(): don't use multi-line strings They aren't supported by elder C compilers ...

Merge branches 'CloakUserHost', 'QuitOnHTTP' and 'bug72-WHOIS-List' * CloakUserHost: Add a note not to use a percent sign ("%") in CloakHost variable Rename ClientHost to CloakHost, and ClientUserNick to CloakUserToNick Don't use "the.net" in sample-ngircd.conf, use "example.net" ngircd.conf.5: document "ClientHost" and "ClientUserNick" Move "ClientHost" and "ClientUserNick" to end of [Global] section ClientUserNick setting ClientHost setting * QuitOnHTTP: Only "handle" HTTP commands on unregistered connections Don't use IRC_QUIT_HTTP() if STRICT_RFC is #define'd IRC_QUIT_HTTP(): enhance error message Move IRC_QUIT_HTTP() below IRC_QUIT() quit on HTTP commands: GET & POST * bug72-WHOIS-List: Add "whois-test" to testsuite and distribution archive Add support for up to 3 targets in WHOIS queries.

Add a note not to use a percent sign ("%") in CloakHost variable The percent sign is reserved for future extensions, for example to expand some variables like %H to a hash value of the real host name ... Idea by kaFux in #ngircd.

Add "whois-test" to testsuite and distribution archive Test script proposed by Dana Dahlstrom, 2008-02-17. See ...

Only "handle" HTTP commands on unregistered connections

Rename ClientHost to CloakHost, and ClientUserNick to CloakUserToNick

Add support for up to 3 targets in WHOIS queries. also allow up to one wildcard query from local hosts. Follows ircd 2.10 implementation rather than RFC 2812. At most 10 entries are returned per wildcard expansion. WHOIS test cases by Dana Dahlstrom.

Don't use IRC_QUIT_HTTP() if STRICT_RFC is #define'd

Doxygen: Remove header.inc.html and ngircd-doc.css from distribution

Don't use "the.net" in sample-ngircd.conf, use "example.net" "the.net" is an existing domain of the Texas Higher Education Network ... See RFC 2606.

IRC_QUIT_HTTP(): enhance error message

ngircd.conf.5: describe types of variables Describe the possible types of variables in ngircd.conf: booleans, text strings, integer numbers. And add type information to each variable description.

Move IRC_QUIT_HTTP() below IRC_QUIT()

ngircd.conf.5: document "ClientHost" and "ClientUserNick"

Move "ClientHost" and "ClientUserNick" to end of [Global] section

quit on HTTP commands: GET & POST

channel: always reject zero-length channel key previously, any client could join in this configuration: [Channel] Name = #test Modes = tnk KeyFile = /tmp/foobar fix this by checking for zero-length key before comparing key to channel key.

ClientUserNick setting

PAM-Auth child: log if result can't be reported This fixes the followin GCC warning on modern Linux systems as well: irc-login.c: In function ‘Hello_User’: irc-login.c:876: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result

ClientHost setting

Protocol.txt: Update description of CHANINFO command

Add cscope.out to .gitignore file

Correctly detect errors when handling "MODE x" commands

Enhance documentation for the WEBIRC command

Doxygen'ify irc-login.c

Doxygen'ify irc-channel.c

Doxygen'ify conn.c