Commits

ngIRCd Release 25

Platforms.txt: Add and update systems - Update x86_64/apple/darwin16.5.0 (Apple clang 8.1) - Add x86_64/apple/darwin17.7.0 (Apple clang 10.0) - Add x86_64/apple/darwin18.2.0 (Apple clang 10.0) - Add x86_64/unknown/haiku (gcc 7.3) - Update x86_64/pc/linux-gnu (gcc 6.3.0)

Fix documentation of MotdPhrase length (#254) The max length is actually 126 (< 127), since the check errors out if length >= 127. See . I didn't look through the history to see when the change happened. I just happened to find during a migration that my 140 character MOTD didn't work. Update sample configuration file as well as the man page.

2019!

Implement new configuration option "MaxPenaltyTime" (#251) This option configures the maximum penalty time increase in seconds, per penalty event. Set to -1 for no limit (the default), 0 to disable penalties altogether. ngIRCd doesn't use penalty increases higher than 2 seconds during normal operation, so values higher than 1 rarely make sense. Disabling (or reducing) penalties can greatly speed up "make check" runs for example, see below, but are mostly a debugging feature and normally not meant to be used on production systems! Some example timings running "make check" from my macOS workstation: - MaxPenaltyTime not set: 4:41,79s - "MaxPenaltyTime = 1": 3:14,71s - "MaxPenaltyTime = 0": 25,46s Closes #249.

Fix compilation without deprecated OpenSSL APIs (#252)

Update Xcode project for latest Xcode version (10.0)

Fix some compiler warnings of Apple Xcode/Clang For example: * src/ngircd/irc-login.c:102:21: Implicit conversion loses integer precision: 'int' to 'char' * src/ngircd/conn.c:1084:9: Implicit conversion turns floating-point number into integer: 'double' to 'bool' * src/tool/tool.c:85:10: Implicit conversion loses integer precision: 'int' to 'char'

Fix typos/errors/... in file comments Found by Xcode/Clang code analyzer. No functional changes.

Update doc/Protocol.txt for IRCv3 WEBIRC extension See commit d0f9d3d92.

Allow a 5th parameter in WEBIRC According to an IRCv3 extension, the 5th parameter can be used for extra flags that are fine to ignore for now, but limiting WEBIRC params to 4 causes a syntax error. See https://github.com/ircv3/ircv3-ideas/issues/12 for more information. This closes #247.

Update HowToRelease.txt: Include the website

Platforms.txt: Add and update systems - Update x86_64/unknown/freebsd10.0 (FreeBSD clang 3.3) - Add x86_64/unknown/freebsd10.3 (FreeBSD clang 3.4) - Update i386/pc/solaris2.11 (gcc 4.8.2) - Add mipsel/openwrt/linux-uclibc (gcc 4.8) [cross-compiler] - Add x86_64/pc/linux-gnu (gcc 5.4.0) [Win10/WSL] - Platforms.txt: Update "pre-ANSI compiler" foot note. Thanks to Götz Hoffart !

ngIRCd Release 25~rc1

Update and fix logcheck(8) rules

Update config.guess and config.sub to recent versions - config.guess: 2018-03-08 - config.sub: 2018-03-08

Initialize listening socket: Streamline error message

Update NEWS and ChangeLog files

Correctly retry outgoing conenctions when forking a resolver failed When ngIRCd failed to spawn a new resolver subprocess, the connection structure was still marked as "SERVER_WAIT", and no new attempt to connect to this server was made. Thanks to Robert Obermeier for reporting this bug! Closes #243.

Fix use-after-free while handling ERROR during client login This patch fixes a "use after free" bug which is hit while processing ERROR commands while a new client is logging into the server, which leads to only the CLIENT structure becoming freed, but not the CONNECTION structure, too. And this leads to the daemon accessing the already freed CLIENT structure later on ... So now IRC_ERROR() uses the correct function Conn_Close() to correctly free both structures. The CONNECTION structure is cleaned up later on, and the freed CLIENT structure can't be overwritten during normal operations, therefore this bug normally can't crash (DoS) the service -- but you can easily hit it when using the GCC option "-fsanitize=address", or run ngIRCd with Valgrind. Thanks a lot to Joseph Bisch for discovering and reporting this issue!

Only send TOPIC updates to a channel when the topic actually changed This prevents the channel from becoming flooded by unecessary TOPIC update messages, that can happen when IRC services try to enforce a certain topic but which is already set (at least on the local server), for example. Therefore still forward it to all servers, but don't inform local clients (still update setter and timestamp information, though!)

Update Xcode project for latest Xcode version (9.2) This includes adding missing and deleting obsolete file references.

Use .mailmap to fix spelling of Götz Hoffart

Little code cleanups, better comments

User mode "C": Allow messages from servers, services, and IRC Ops Update user mode "C" handling ("Only users that share a channel are allowed to send messages") to behave like user mode "b" ("block private messages and notices") and therefore allow messages from servers, services, and IRC Operators, too. Change proposed by "wowaname" in #ngircd, thanks!

portab/Makefile: Split list into separate lines

configure.ng: Split list into separate lines

Update NEWS and ChangeLog files

2018!

Fix compiler warning in ForwardLookup() When compiling without "working getaddrinfo()", the "af" parameter of ForwardLookup() is unused by that function. Mark it as such! This prevents the following compiler warning: resolve.c:235:56: warning: unused parameter ‘af’ [-Wunused-parameter]

Fix compiler warning in Option_String() When compiling ngIRCd without support for SSL and without support for ZLIB, gcc outputs the following warning: irc.c:493:9: warning: variable ‘options’ set but not used [-Wunused-but-set-variable] Fix it by providing a dummy function in this case.

Fix Get_Error() usage, take II This should fix the following compiler warning: resolve.c:113:1: warning: ‘Get_Error’ defined but not used [-Wunused-function] Which can happen, because the logic of commit 543f44bf isn't sufficient: Get_Error() is only used when neither HAVE_WORKING_GETADDRINFO nor HAVE_GETNAMEINFO are set ... Enhances 543f44bf. Closes #241.

contrib/ngircd.logcheck: Add sample logcheck(8) rules

Allow IRC Ops and remote servers to KILL service clients (#242) In the end, service clients behave like regular users, therefore IRC operators and servers should be able to KILL them: for example to resolve nick collisions. This is related to #238.

Don't forward KILLs to other servers if they've been blocked locally This prevents clients from killing IRC services, for example. Closes #238. Closes #239.

Update AUTHORS file

Merge pull request #240 from bkuhls/fix_Get_Error Fix Get_Error usage

Fix Get_error usage The usage of Get_Error is guarded by "ifdef h_errno" in this file, the definition of this function should follow the same rules. Fixes a build error when cross-compiling: https://github.com/ngircd/ngircd/issues/223

Update HowToRelease.txt - Freshmeat is no more, and - GitHub issues doesn't allow us to configure "releases".

Services.txt: Show Atheme "name" in example configuration

Services.txt: Show ngIRCd "Name" in example configuration

ngIRCd Release 24

Platforms.txt: Add and update systems - Update i386/unknown/freebsd7.3 (gcc 4.2.1) - Update i386/unknown/netbsdelf4.0 (gcc 4.1.2) - Update x86_64/apple/darwin16.3.0 (Apple clang 8.0) - Update x86_64/unknown/freebsd8.4 (gcc 4.2.1) - Update x86_64/pc/linux-gnu (gcc 4.4.5) - Update x86_64/pc/linux-gnu (gcc 4.8.4) - Update x86_64/pc/linux-gnu (gcc 4.9.2) - Update x86_64/pc/linux-gnu (gcc 6.2.1) - Add x86_64/pc/linux-gnu (gcc 6.3.1)

Make sure that platformtest.sh aborts when autogen.sh fails

Specify Debian "source format"

Update config.guess and config.sub to recent versions - config.guess: 2016-10-02 - config.sub: 2016-11-04

Build Debian packages with OpenSSL instead of GnuTLS OpenSSL allows to reload used certificates on runtime for example (which is very useful when using Let's Encrypt), and therefore is preferred ...

Fix handling of connection pool allocation and enlargement The daemon only enlarged its connection pool when accepting new client connections, not when establishing new outgoing server links. Thanks to Lukas Braun (k00mi) for reporting this! In addition this patch streamlines the connection pool allocation, so that there is only one place in the code allocating the pool: the now updated Socket2Index() function. The name doesn't quite fit, but this existing and today quite useless function (because the mapping from socket number to connection index is 1:1 today) already became called in almost all relevant code paths, so I decided to reuse it to keep the patch small ...probably we want to fix the naming in a second patch? Closes #231.

2017!

Update doc/RFC.txt, add RFC 7194

ngIRCd Release 24~rc1

Debian: Use "dh_prep" instead deprecated "dh_clean -k"

ngircd.conf.5.tmpl: Fix spelling Thanks to Christoph Biedl.

Platforms.txt: Add and update systems - Add x86_64/apple/darwin16.3.0 (Apple clang 8.0) - Update x86_64/pc/linux-gnu (gcc 4.9.2) - Add x86_64/pc/linux-gnu (gcc 6.2.1.)

Further enhance systemd unit file - Add more comments/documentation. - Add dependencies for services and proxy scanners. - Add more limit configurations. - Allow AF_UNIX address family, required for syslog!

Install systemd service file in Debian package

Enhance systemd service file - Add homepage :-) - Remote CAP_SETUID and CAP_SETGID from CapabilityBoundingSet: This is nor needed, because the unit already sets User=irc and Group=irc. - Add RestrictAddressFamilies, and restrict it to AF_INET and AF_INET6. - Read in the Debian "default files", but note: only PARAMS is supported!

Update Debian package - Update debhelper compatibility to version 9. - Update build-dependencies. - Change group of ngircd.conf to "irc" in postinst script (this makes starting ngIRCd as user "irc" easier, for example when using systemd). - Don't create /var/run/ircd during installation: this is handled by the SysV init script and the systemd service already.

Update NEWS and ChangeLog files

Log privilege violations and failed OPER as "error" and to &server

Immediately shut down connection on receiving ERROR Don't wait for the peer to close the connection. This allows us to forward the ERROR mesage in the network, instead of the very generic "client closed connection" message.

Xcode: Fix "duplicate symbols" error in current Xcode

x-Line synchronization: Don't send negative durations

List expiration: use same log level as when setting And log this event to the &SERVER channel, too.

Remove leftover debug message. Oops!

G-LINES: Forbid remote modifications if "AllowRemoteOper" is not set Explicitely forbid remote servers to modify "x-lines" (G-LINES) when the "AllowRemoteOper" configuration option isn't set, even when the command seems to originate from the remote server itself: this prevents GLINE's to become set during server handshake in this case (what wouldn't be possible during regular runtime when a remote IRC Op sends the command) and what can't be undone by IRC Ops later on (because of the missing "AllowRemoteOper" option) ...

Make scripts and init-files in ./contrib executable

autogen.sh: Fix some shellcheck(1) warning messages

Fix building ngIRCd with OpenSSL 1.1 At the moment, ngIRCd fails to build against OpenSSL 1.1 since the configure check probes for the SSL_library_init symbol which was removed, but probing for a different function availabe in both versions solves that problem: SSL_new(). And as SSL_library_init is no longer needed, the patch boils down to probing SSL_new to assert libssl is available, and disabling the SSL_library_init invokation from OpenSSL 1.1 on, see also another application[1] (NSCA-ng) that did pretty much the same. Patch was compile-tested on both Debian jessie (OpenSSL 1.0.2) and stretch (OpenSSL 1.1). [1] (Patch by Christoph, commit message cherry-picked from the email thread on the mailing list by Alex. Thanks!)

gcc 6.2 warnings: fix code indentation This fixes the following correct -Wmisleading-indentation warning messages of gcc 6.2: irc-write.c: In function ‘IRC_SendWallops’: irc-write.c:521:4: warning: this ‘if’ clause does not guard... irc-write.c:524:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’ irc-write.c:526:4: warning: this ‘if’ clause does not guard... [] irc-write.c:529:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’ irc-info.c: In function ‘IRC_STATS’: irc-info.c:895:3: warning: this ‘else’ clause does not guard... irc-info.c:897:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘else’ No functional changes, the code has been correct, but the indentation was wrong ...

Update config.guess and config.sub to recent versions - config.guess: 2016-04-02 - config.sub: 2016-03-30

Platforms.txt: Update systems - Update x86_64/apple/darwin15.6.0 (Apple clang 8.0) - Update x86_64/unknown/linux-gnu (gcc 4.9.2) - Update i386/pc/solaris2.11 (gcc 4.8.2), tests have been run both on Solaris 11.2 and Solaris 11.3 successfully, but the system identifier is the same ... Thanks to Götz Hoffart !

PAM.txt: Add note about /etc/pam.d/ngircd permissions

autogen.sh, ngindent, platformtest.sh: Fix warnings of "shellcheck" - SC2006: Use $(..) instead of legacy `..`. - SC2015: Note that A && B || C is not if-then-else. C may run when A is true. - SC2086: Double quote to prevent globbing and word splitting. - SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.

Update Xcode project for latest Xcode version (8.0)

Update Xcode project for latest Xcode version (7.3)

Updated config.sub to version 2014-09-11

Add "Documentation" variables to systemd configuration files

Make sure that SYSCONFDIR is always set This is useful when ./configure hasn't been run but some source code linters are run in an editor, for example.

Add "PAMServiceName" configuration option This setting allows to run multiple ngIRCd instances with separate PAM configurations on each instance. If one sets it to ngircd-foo, PAM will use /etc/pam.d/ngircd-foo instead of the default /etc/pam.d/ngircd. Thanks to "somechris" for the patch & pull request! Closes #226.

Add PAMServiceName setting to specify the used PAM configuration This setting allows to run multiple ngIRCd instances with PAM configurations on each instance. If one sets it to "ngircd-foo", PAM will use `/etc/pam.d/ngircd-foo` instead of the default `/etc/pam.d/ngircd`.

Add an ".editorconfig" file to the project

Platforms.txt: Remove x86_64/unknown/linux-gnu, tcc 0.9.25 This combination had been successfully tested with ngIRCd 21, but after further investigation didn't build correctly: it seems as if tcc fails to correctly link external libraries (e. g. ngipaddr). Astonishingly the test suite passed nevertheless, with garbled output, but without the daemon crashing!? When using tcc with ngIRCd 23 (and current master), the test suite fails completely because the daemon crashes ... (which actually is good!)

Platforms.txt: Add systems - Add armv7l/unk./linux-gnueabihf (gcc 4.9.2) - Add x86_64/unknown/linux-gnu (icc 16)

Travis-CI: use "container-based infrastructure" See for details.

platformtest.sh: Delete ngIRCd binary before test run This ensures that we definitely don't test an old binary later on ...

platformtest.sh: Only show "runs=Y" when test suite succeeded Display "?" in the "runs" colum when the simple "run test" succeeded but the test suite failed. And display a message to double check the actual status, because it is somewhat unclear, if the daemon actually "works" or not in this case.

Platforms.txt: Add and update systems - Add i386/pc/minix (clang 3.4) - Update i686/pc/cygwin (gcc 4.9.3) - Add x86_64/apple/darwin15.2.0 (Apple clang 7.0)

Send_Message: Fix handling of "empty" targets Clients can specify multiple targets for the "PRIVMSG", "NOTICE", and "SQUERY" commands, separated by commas (e. g. "PRIVMSG a,#b,c :text"). Since commit 49ab79d0 ("Limit the number of message targes, and suppress duplicates"), ngIRCd crashed when the client sent the separator character only as target(s), e. g. "," or ",,,," etc.! This patch fixes the bug and adds a test case for this issue. Thanks to Florian Westphal for spotting the issue!

Update README file

Platforms.txt: Add and update systems - Update i586/pc/interix3.5 (gcc 3.3) - Add i686/pc/linux-gnu (gcc 2.6.3) - Add i686/pc/linux-gnu (gcc 2.95.2) Thanks to Götz Hoffart !

platformtest.sh: Use $LOGNAME instead of $USER LOGNAME is more standard than USER.

Update copyright notices for 2016

Limit the number of message targes, and suppress duplicates This prevents an user from flooding the server using commands like this: PRIVMSG nick1,nick1,nick1,... Duplicate targets are suppressed silently (channels and clients). In addition, the maximum number of targets per PRIVMSG/NOTICE/... command are limited to MAX_HNDL_TARGETS (25). If there are more, the daemon sends the new 407 (ERR_TOOMANYTARGETS_MSG) numeric, containing the first target that hasn't been handled any more. Closes #187.

Add "_MSG" postfix to ERR_WILDTOPLEVEL_MSG

Commands.txt, PRIVMSG: Fix "server mask" description

Enahnce comments for Send_Message() and Send_Message_Mask() No functional changes.

Get rid of unclever assert() in Send_Message_Mask() Either we use assert() to _guarantee_ a certain condition, or we use if(...) to test for it. But never both. So get rid of the assert() in Send_Message_Mask() and handle the case that the target mask doesn't contain a dot (".") as regular error, don't require the caller to assure that any more. This polishes commit 5a312824. Please note: The test in Send_Message() is still _required_ to detect whether the target is a channel (no dot) or a "target mask" (at least one dot)!

Test suite: Add new test for server-server logins This test detects the recent NJOIN breakage, for example ...

Fix NJOIN handler killing all clients This bug has been introduced by commit 1e386fb7ac which had the logic reversed :-( Reported by "ninguno" in #ngircd, thanks a lot!

contrib/ngindent: Fix shebang line

contrib/platformtest.sh: Warn when external tools are missing

contrib/platformtest.sh: Make script more portable

Platforms.txt: Add and update systems - Update i386/unknown/openbsd3.5 (gcc 2.95.3) - Update i686/pc/linux-gnu (gcc 2.7.2.1) - Add x86_64/unknown/linux-gnu (gcc 5.3.0) Thanks to Götz Hoffart !

doc/Platforms.txt: Sort list

Make NJOIN handler more fault-tolerant Don't crash the daemon when the NJOIN handler can't join the new client to a channel (when the Channel_Join() function failed) but try to KILL this client -- which is the only possible reaction besides crashing: otherwise the network would get out of sync.

IRC_KillClient(): Don't break when called without "Client" The IRC_KillClient() function is documented to handle the case that the "Client" structure is NULL, so make sure that this actually works and can't crash the daemon. Please note: The current code doesn't make use of this feature, so this fix is definitely the "right" thing to do but doesn't fix an actual problem.

IRC_NJOIN(): Code cleanup No functional changes.

Modes.txt: Add "name prefixes" to channel user mode description

Fix NJOIN not propagating "half ops" status ngIRCd tested for the wrong prefix of "half ops" when processing NJOIN commands and therefore never classified a remote user as "half op". Thanks to wowaname for pointing this out on #ngircd!

ngIRCd Release 23

Update ChangeLog file

Update doc/Platforms.txt

Explicitly cast time_t to long when printing it out This prevents wrong sizes data types on platforms where time_t doesn't equal a long any more, for example on OpenBSD.

contrib/Debian/changelog: Fix email address

Documentation: Spelling fixes

ngIRCd Release 23~rc1

Update AUTHORS and .mailmap file And add a note to doc/HowToRelease.txt to not forget to update the list of authors in the future ...

Update ChangeLog file

Add ".clang_complete" file This file is used of the "linter-clang" package of the Atom editor, for example.

Make server-to-server protocol more robust Now ngIRCd catches more errors on the server-to-server (S2S) protocol that could crash the daemon before. This hasn't been a real problem because the IRC S2S protocol is "trusted" by design, but the behavior is much better now. Thanks to wowaname on #ngircd for pointing this out!

platformtest.sh: Fix quoting

autogen.sh: Fix parameter quoting

ngircd.init: Fix non-POSIX "==" test operator

Reproducible builds At the moment ngircd fails the tests for reproducible builds in Debian since it uses the __DATE__ and __TIME__ macros for the INFO command. Instead of patching this out I decided to implement an optional constant BIRTHTIME that allows you to set a time stamp for the "Birth Date" information, in seconds since the epoch, like in export CFLAGS += -DBIRTHTIME=$(shell date +%s --date="2015/08/15 23:42:22") In the future, Debian will provide a SOURCE_DATE_EPOCH environment variable, dealing with the situation until then will be my job. The time format was taken from the NGIRCd_StartStr formatting in ngircd.c so the "Birth Date" and "On-line since" lines in the INFO output look similar: :irc.example.net 371 nick :ngIRCd 22.1-IDENT+IPv6+IRCPLUS+PAM+SSL+SYSLOG+ZLIB-x86_64/pc/linux-gnu :irc.example.net 371 nick :Birth Date: Tue Aug 25 2015 at 18:11:11 (CEST) :irc.example.net 371 nick :On-line since Tue Aug 25 2015 at 18:11:33 (CEST) :irc.example.net 374 nick :End of INFO list The format of the time stamped is changed, but as far as I can tell, there's no rule that is violated by that. Bonus level: Reformat the messages so the time stamps are aligned.

Update systemd service file

Update NEWS and ChangeLog files

Whitespace fixes (no functional changes)

Fix debug message "Client ... is closing connection" It should be "host:port"!

INSTALL: Add deprecation notice for "PredefChannelsOnly" Obviously I forgot to list this for ngIRCd 21 ... oops!

"NoticeAuth" configuration variable is deprecated now!

Merge pull request #217 from SaberUK/master+notice-auth Use "NOTICE *" before registration instead of "NOTICE AUTH".

Channel mode "N" is targeted for ngIRCd 23.

Rename NoticeAuth to NoticeBeforeRegistration. The old name is still supported for compatibility reasons.

First check if channel has mode "N", then check membership This should be more efficient.

Use "NOTICE *" before registration instead of "NOTICE AUTH". AUTH is a valid nickname so sending notices to it is probably not a good idea. Use * as the target instead as done with numerics when the nick is not available. This mimics the behaviour in Charybdis, IRCD-Hybrid, InspIRCd 2.2, Plexus 4, etc.

Merge pull request #214 from Flupsy/channel-mode-N Channel mode N (users on this channel can't change their nick)

Merge pull request #215 from tejr/master Specify session context for OpenSSL clients. Closes #182.

Add "build+*" to .gitignore file

Only enforce channel mode N on users (not servers or services)

Specify session context for OpenSSL clients Reconnecting to ngIRCd 22.1 built with OpenSSL with some OpenSSL clients, including Pidgin and stunnel 5.06, attempts to reuse a session and fails due to the absence of this line. The error message in syslog from ngIRCd is: > SSL protocol error: SSL_accept (error:140D9115:SSL > routines:SSL_GET_PREV_SESSION:session id context uninitialized) This patch appears to fix the problem for both Pidgin and stunnel; it may work for other OpenSSL clients that attempt to re-use sessions. * * *

Fix several broken URLs.

Remote GIT.txt from Makefile[.am], too!

Don't bother looking for +N channels for an op

Merge remote-tracking branch 'LucentW/master' * LucentW/master: Fix with oneshot invites Fixed building issues\ Implement timestamp tracking of invites Keep track of who placed bans/invites/excepts IRC operators w/OperCanMode can kick anyone [already cherry-picked] Closes #203, Closes #205.

READNE, AUTHORS: Update mailing list and issue tracker URLs

Don't use a standard message number

Make setgroups(3) function optional For example, Interix is missing this function, which prevented ngIRCd to build on this platform. When setgroups(3) isn't available, a warning message is issued when ngIRCd starts up.

Fix with oneshot invites This should finally implement correctly oneshot invites sent via /INVITE

doc/Contributing.txt: Add note about using GitHub

Add documentation for channel mode N

IRC operators w/OperCanMode can kick anyone Closes #202. (cherry picked from commit 10c7ba99e73b42ec8c4c191ccdae60bdd35bba7d)

Fixed building issues\ Now builds cleanly. Pass all tests from make check.

Remove doc/GIT.txt: it is outdated ngIRCd uses GitHub, and Git itself is quite common today. So don't include an own Git "mini HowTo" any longer.

Add channel mode N (normal user can't change nick while on channel)

Implement numeric RPL_LISTSTART(321) lightIRC and other clients expecting RPL_LISTSTART should now behave correctly. Closes #207. (cherry picked from commit 0680ce5fd99bc643651d1433bcdaf271aeb73c46)

Implement timestamp tracking of invites Now lists nodes also have the "onlyonce" field, since the valid_until is used to keep the timestamp of placing. Found no references to onlyonce or about valid_until being == 1, though, so it might be unused, but still available for other enhancements.

Streamline ".gitignore" files

Update ngircd.conf.5: "CloadUserToNick" hides user and real name Closes #208.

Keep track of who placed bans/invites/excepts Implements #203. WARNING: it does not track the time of placement of invites, since the time_t is already used as a flag for single use invites!

Update NEWS and ChangeLog files

Fix MatchCaseInsensitive[List]](): lowercase string _and_ pattern Up to now, only the the string ("haystack") became lowercased and was the compared to the pattern ("needle") -- which failed, when the pattern itself wasn't all lowercase ...

IRC operators w/OperCanMode can kick anyone

Streamline effect of "MorePrivacy" option (WHOIS, LIST) - Update documentation in ngircd.conf(5) - LIST: Don't hide channels for IRC Ops when "MorePrivacy" is in effect - WHOIS: Don't hide IP addresses/hostnames when "MorePrivacy" is in effect Closes #198

doc/Modes.txt: Fix indentation

Merge pull request #197 from LucentW/master Implement user mode "I": Hide channels on WHOIS User mode +I prevents ngIRCd from showing channels on WHOIS. IRC Operators can always see those. Closes #197.

Fixed indents 2

Make sure that the target user is able to join a local channel Implement ERR_USERNOTONSERV(504) numeric and make sure that the target user is on the same server when inviting other users to local ("&") channels. ircd-ratbox uses the ERR_USERNOTONSERV(504) numeric for this, and I think this is a good idea -- other IRC daemons (like ircu) silently drop such impossible invites, but thats not a big benefit ... Idea by Cahata, thanks! Closes #183.

Fixed indents and documentation (also updated the copyright date on the txt I edited)

INVITE command: Enforce 1 second penalty time This prevents flooding of the target client. This closes #186. Reported by Cahata, thanks!

Implement +I (private channel list on whois) Implements enhancement requested in issue #179

MODE command: Always report channel creation time Up to now when receiving a MODE command, ngIRCd only reported the channel creation time to clients that were members of the channel. This patch reports the channel creation time to all clients, regardless if they are joined to that channel or not. At least ircd-seven behaves like this. This closes #188. Thanks Cahata!

Update Xcode project for latest Xcode version (6.3)

ngIRCd Release 22.1

Update NEWS and ChangeLog for ngIRCd 22.1

Update some copyright notices for 2015

Platforms.txt: Add and update systems - Update powerpc/apple/darwin7.9.0 Thanks to Götz Hoffart !

Fix spelling of RPL_WHOISBOT message text

Don't send nick name as default PART reason No other IRC daemon seems to do this (today?), don't remember why ngIRCd did it in the first place ... Closes #185. Reported by Cahata in #ngircd, thanks!

Fix "WHO #" showing invisible users and hiding all visible The logic is reversed ... This bug has been introduced by commit c74115f2, "Simplify mode checking on channels and users within a channel", ngIRCd releases 21, 21.1, and 22 are affected :-( Problem reported by Cahata in #ngircd, Thanks!

Fix typo in src/testsuite/README

Auth PING: Fix our information text for manual sending of "PONG" Up to now, ngIRCd doesn't send a valid IRC command at all, oops!

Auth PING: The numeric ID is a "long", use atol()

Auth PING: Don't send a prefix in our PING command The prefix confuses WeeChat, at least, which doesn't send an appropriate PONG in the case ... Debugging and patch by "wowaname" on #ngircd, thanks!

FAQ: How can I "auto-op" users in channels?

Fix syntax of ERR_LISTFULL_MSG(478) numeric Pointed out by "wowaname" in #ngircd, thanks!

Enhance debug messages while sending CHANINFO commands

Reset "last try" timer when enabling a passive server This results in a new connection attempt as soon as possible.

Change log message for "Can't resolve address"

Change log messages issued for IP address forgeries

Merge remote-tracking branch 'alex/TestsuiteNoDNS' * alex/TestsuiteNoDNS: Test suite: Don't use DNS lookups

Merge branch 'CipherListNoSSL3' * CipherListNoSSL3: INSTALL: List the changed SSL CipherList default value. Update "CipherList" to not enable SSLv3 by default

Test suite: Don't use DNS lookups Different operating systems do behave quite differently when doing DNS lookups, for example "127.0.0.1" sometimes resolves to "localhost" and sometimes to "localhost.localdomain" (for example OpenBSD). And other systems resolve "localhost" to the real host name (for example Cygwin). So not using DNS at all makes the test site much more portable.

INSTALL: List the changed SSL CipherList default value.

HowToRelease.txt: Add note about the bug tracker

Add "tests-skipped.lst" to src/testsuite/.gitignore

Update "CipherList" to not enable SSLv3 by default Idea, initial patch, and testing by Christoph Biedl

ngIRCd Release 22

Test suite/platformtest.sh: Detect when tests have been skipped Detect if some tests have been skipped, for example when telnet(1) or expect(1) is missing: ./contrib/platformtest.sh will echo a warning message now.

Platforms.txt: Add and update systems - Add armv7l/unk./linux-gnueabihf - Update hppa/unknown/openbsd5.4 - Update i686/unknown/gnu0.5 - Update i686/pc/cygwin - Add i386/pc/linux-gnu, gcc 4.4.5 - Update x86_64/apple/darwin14.0.0 - Update x86_64/unknown/freebsd8.4 - Update x86_64/unknown/freebsd9.2 - Add x86_64/unknown/freebsd10.0 - Add/update x86_64/unknown/linux-gnu, various compilers - Update x86_64/unknown/openbsd4.8 - Add x86_64/unknown/openbsd5.5 Tested version is "rel-22-rc1-3-g967deeb".

Platforms.txt: Add and update systems - Add sparc/unknown/openbsd5.5 - Update powerpc/apple/darwin7.9.0 - Update x86_64/unknown/linux-gnu, Open64 - Update x86_64/unknown/linux-gnu, Sun C 5.12/Solaris Studio 12.3 - Update x86_64/unknown/linux-gnu, tcc 0.9.25 Thanks to Götz Hoffart !

User mode "F": Fix description in NEWS and ChangeLog

Add "cov-int" directory (Coverity test tool) to .gitignore file

Update NEWS and ChangeLog for ngIRCd 22 once more ...

Test suite: Update file headers and comments

Match list patterns case-insensitive The invite-, ban-, and except lists are affected by this change, as well as G-Lines an K-Lines. Problem pointed out by "wowaname" on #ngircd, thanks!

Update links to "Arthur" to use the HTTP protocol

ngIRCd Release 22~rc1

ngIRCd Release 21.1 (cherry picked from commit ee28e76df2a73f3bb4bcf69c644eae9a10298a58)

Update NEWS and ChangeLog for ngIRCd 22 once more ...

Platforms.txt: Update i686/unknown/gnu0.5

Sync "except lists" between servers Up to now, ban, invite, and G-Line lists have been synced between servers while linking -- but obviously nobody noticed that except list have been missing ever since. Until now. Thanks to "j4jackj", who reported this issue in #ngircd.

Platforms.txt: Update powerpc/apple/darwin7.9.0 - Update powerpc/apple/darwin7.9.0, gcc 3.3 Thanks to Götz Hoffart !

Allow longer usernames for authentication

Platforms.txt: Update x86_64/unkn./linux-gnu, clang 3.x - Update x86_64/unknown/linux-gnu, clang 3.2 => clang 3.3

Correctly check that a server has a valid hostname and port David Binderman reported the following compiler warning, which is a real bug in ngIRCd, thanks! conn.c:2077:55: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]

Platforms.txt: Add and update more systems - update i686/pc/linux-gnu, gcc 2.7.2 - update powerpc/apple/darwin6.8, gcc 3.1 - add powerpc/apple/darwin9.8.0, gcc 4.0.1 Thanks to Götz Hoffart !

Fix spelling and whitespaces in INSTALL

doc/Bopm.txt: Update file header

Update NEWS and ChangeLog for ngIRCd 22

doc/Bopm.txt: Update "connregex" and "kline" for current ngIRCd Thanks to "kerin" on IRC for pointing this out!

Lists_MakeMask: Don't destroy source buffer

Allow "DefaultUserModes" to set all possible modes Let IRC_MODE() detect that the "fake" MODE command originated on the local sever, which enables all modes to be settable using "DefaultUserModes" that can be set by regular MODE commands, including modes only settable by IRC Operators.

Initialize Conf_ScrubCTCP even when SYSLOG isn't #define'd The "SYSLOG" #define isn't related to "Conf_ScrubCTCP" at all, so initialize the latter even when "SYSLOG" isn't #define'd. Pointed out by wowaname on #ngircd, thanks!

Spoofed prefixes: Really kill connection on non-server links This fixes commit 6cbe1308 which only killed the connection when the spoofed prefix itself belonged to a non-server client.

Platforms.txt: Add and update systems - Add armv7l/unk./linux-gnueabihf - Add x86_64/apple/darwin14.0.0 Thanks to Götz Hoffart !

Implement user mode "F": "relaxed flood protection" ngIRCd relaxes its flood protection for users having the user mode "F" set and allows them to rapidly send data to the daemon. This mode is only settable by IRC Operators and can cause problems in the network -- so be careful and only set it on "trusted" clients! User mode "F" is used by Bahamut for this purpose, for example, see .

Increase MAX_SERVERS from 16 to 64 There are installations out there that would like to configure more than 16 links per server, so increase this limit. Best would be to get rid of MAX_SERVERS altogether and make if fully dynamic, but start with this quick and dirty hack ...

Handle "throttling" in a single function ngIRCd uses "command throttling" and "bps throttling" (bytes per second). The states are detected in different functions, Conn_Handler() and Read_Request(), but handle the actual "throttling" in a common function: this enables us to guarantee consistent behavior and to disable throttling for special connections in only one place, eventually.

New "Debian release" 21.1-0ab2 (cherry picked from commit 48fcb97fa4a2762a873d9d693c7a126588a1811d)

Updated config.{guess|sub} to version 2014-03-13

Debian: Don't adjust path names that are correct by default

Streamline DEBUG_ARRAY, DEBUG_BUFFER, DEBUG_IO, DEBUG_ZIP Change all #define's to follow the form #define DEBUG_xxx {0|1} to disable (0, default) or enable (1) additional debug messages. And somewhat enhance some DEBUG_BUFFER messages.

Debian: Correctly set and use "docdir"

conn.c: Code cleanup Reformat and restructure some code, move all SSL related code into one single #ifdef block, for example.

Update config.guess and config.sub to recent versions - config.guess: 2014-03-23 - config.sub: 2014-05-01

Xcode: remove imp.h and exp.h from project file These files have been removed from ngIRCd in commit 259c314d, "Remove imp.h and exp.h header files".

Re-add #include's for header files of the C file itself This partially reverts commit b130b35f4, "Update #include's: remove unused and add missing ones", but fixes the following compiler and analyzer warnings of Apple Xcode 5: "Semantic issue: No previous prototype for function 'yyy'"

Update copyright notices of recently changed files

Update #include's: remove unused and add missing ones The "deheader" tool () has been used to find unused #include directives as well as missing ones. Tested on: - A/UX 3.1.1 - ArchLinux (2014-03-17) - Debian GNU/Hurd - Debian GNU/Linux 6.0.9 - Debian GNU/Linux 7.4 - Fedora 20 - FreeBSD 9.2 - OpenBSD 4.8 - OpenBSD 5.1 - OS X 10.9 - Solaris 11

portab.h: Restructure and clean up code - Don't use HAVE_SYS_TYPES_H, is a required header now. - Streamline check for boolean data types. - Better indent #ifdef constructs.

configure[.ng]: is a required header file ngIRCd already includes in a lot of places without checking for its existence (for example in "ngircd.c", "io.c", ...), therefore make it a required header file.

io.c: is only needed when using select() Only include the header when using the select() IO API, it isn't required otherwise.

Remove imp.h and exp.h header files These include files don't have a function any more, remove them.

strdup.c: Code cleanup

Don't define SSL_Want{Read|Write}() when SSL is disabled Not even call the "dummy" functions.

Code cleanup, remove blank lines

Fix two K&R C portability issues Fix the following two errors emitted by the Apple K&R C compiler on Apple A/UX: "./class.c", line 47: no automatic aggregate initialization "./class.c", line 47: illegal lhs of assignment operator "./conf.c", line 1052: syntax error Tested on A/UX 3.1.1.

Merge pull request #6 from norrs/pam_server_password_fix Validate server password when PAM is disabled.

Use server password when PAM is compiled in but disabled

CHARCONV: Fix handling conversion errors Don't overwrite already converted text!

Streamline punctuation of log messages See commit d38d153f for details.

Services.txt: Update information for Anope 2.x

IRC_INVITE(): Code cleanup

Streamline punctuation of log messages See commit d38d153f for details.

Correctly use cloaked IRC masks on "INVITE nickname" The cloaked IRC mask of a user is his visible mask, so the daemon has to use it for generating the "one time" entries for the invite list of the given channel. Without this patch, ngIRCd records the real IRC mask which will never match while the target client is "+x", and even worse, will disclose the real mask on "MODE #channel +I" commands :-/ Bug reported by Cahata on #ngircd, thanks!

Use correct sender as target for ISUPPORT replies on "VERSION" This fixes commit 2e168c78 ("Return ISUPPORT(005) numerics on 'VERSION'") and make sure, that the 005 numerics are correctly routed back to the sender.

Return ISUPPORT(005) numerics on "VERSION" This is how ircd-seven, Charybdis, Hybrid, and InspIRCd behave, for example.

configure: Only link "contrib/Debian" if it exists This isn't the case on "VPATH builds", for example.

Merge pull request #5 from grawity/accountname-whois Show account name in WHOIS

Show account name in WHOIS This uses the same numeric as Charybdis and ircu families.

ngircd.conf.5: Update manual page

Merge branch 'no-range-matching' of git://arthur.barton.de/ngircd-alex * 'no-range-matching' of git://arthur.barton.de/ngircd-alex: Remove "range matching" functionality

Use $(MKDIR_P) instead of $(mkinstalldirs) in Makefile's And test for "mkdir -p" using AC_PROG_MKDIR_P in "configure".

Remove "range matching" functionality Don't support "range marching" in our pattern matching code using the "[...]" syntax, because [ and ] are valid characters in nick names and one has to quote them currently using the "\" character, which is quite unexpected. For example: Nick "te[st" => "MODE #channel +b te\[st" And remove quoting altogether, too, because "*" and "?" don't need to be quoted because these characters are not allowed in IRC masks, nicks, and hostnames. Reported by "hifi" (Toni Spets) on IRC, thanks!

Fix configure script and "make check" for TCP Wrappers Add missing #include's and static variables. Problem spotted on OpenBSD.

platformtest.sh: Allow using separate source and build trees Now you can call platformtest.sh using its complete path name from an other directory which is then used for building. See Please not that the build system itself is still (re-)genrated in the original source tree. This can be avoided by passing the "-x" switch to the platformtest.sh script.

Add libwrap at the end of the configure run If libwrap becomes added earlier, other tests may fail because of not all external variables required by libwrap are available when linking: for example allow_severity and deny_severity. This patch adds generic support for the LDFLAGS_END and LIBS_END variables (CFLAGS_END has been implemented already). Problem spotted on OpenBSD.

platformtest.sh: Show only up to 10 bytes of version information

platformtest.sh: New option "-x", don't renegerate build system

Client_SetHostname(): Don't use strlen() to test for value

Test suite: explicitely enable glibc memory checking

Send "fake '*' key" in "MODE -k" replies According to RFC 2812 3.2.3 "Channel mode message" and the examples there, it looks like clients should use "MODE -k " to unset channel keys; and that's how other servers and services behave and do expect it. (But please note that this is NOT the case for "MODE -l"!) In the end, it doesn't make sense to specify a key when UNsetting it at all, and different services behave diffrently when clients do not send the currently set key to unset it - some ignore such calls, for example! But this implementation is quite relaxed, it accepts any key when unsetting channel mode "k" and even accepts no key at all. But the reply will always include an "*" character for every "-k" parameter.

Add "config.cache" to .gitignore file

platformtest.sh: don't use "test -e", it isn't portable

Makefile.am: don't use "test -e", it isn't portable

Support non-standard vsnprintf() return code C99 states that vsnprintf() "returns the number of characters that would have been printed if the n were unlimited"; but according to the Linux manual page "glibc until 2.0.6 would return -1 when the output was truncated" -- so we have to handle both cases ...

Partially revert bc098794: don't require autoconf 2.67 GNU autoconf 2.61 is still sufficient to generate the configure script, even after updating configure.{ng|in}, so don't require a newer version.

doc/Platforms.txt: Update some systems to ngIRCd 21 - update i686/pc/cygwin, gcc 4.8.2 - update x86_64/apple/darwin13.0.0, Apple clang 5.0 - update x86_64/unknown/freebsd8.4, gcc 4.2.1 - update x86_64/unknown/freebsd9.1, gcc 4.2.1 - update x86_64/unknown/linux-gnu, gcc 4.8.2 - update x86_64/unknown/linux-gnu, Open64 - update x86_64/unknown/openbsd4.8, gcc 4.2.1 - update x86_64/unknown/openbsd5.1, gcc 4.2.1

Update configure.ng for autoconf 2.67 We already require GNU autoconf 2.67 for generating our build system (at least this is what the INSTALL document states), so update the build system accordingly and implement all changes that autoupdate(1) suggests: - Update AC_PREREQ and AC_INIT - Use AC_LINK_IFELSE, AC_RUN_IFELSE, and AC_COMPILE_IFELSE - Remove AC_TYPE_SIGNAL (we don't use RETSIGTYPE)

Update Copyright notices for 2014

Merge branch 'bug167-WebircIPAnoDNS' of git://arthur.barton.de/ngircd-alex * 'bug167-WebircIPAnoDNS' of git://arthur.barton.de/ngircd-alex: WEBIRC: Don't respect hostname when DNS is disabled

Merge branch 'bug165-005-NETWORK' of git://arthur.barton.de/ngircd-alex * 'bug165-005-NETWORK' of git://arthur.barton.de/ngircd-alex: Implement new configuration option "Network"

WEBIRC: Don't respect hostname when DNS is disabled When DNS lookups are disabled, don't set the hostname received by the WEBIRC command, but use the IP address instead. Reported by Toni Spets , thanks! Closes bug #167.

portabtest: Add checks for strdup(), strndup(), and strtok_r()

Implement new configuration option "Network" The new configuration variable "Network" is used to set the (completely optional) "network name", to which this instance of the daemon belongs. When set, this name is used in the ISUPPORT(005) numeric which is sent to all clients connecting to the server after logging in. Closes bug #165.

OS X has a working getaddrinfo() implementation

portabtest: Actually test functions Test functions snprintf(), strlcpy(), strlcat(), vsnprintf() for correctness, not only existance (which was quite useless, because if they weren't available, the program could not have been linked at all ...).

Check for working getaddrinfo() function At least AIX 4.3.3 and 5.1 have a broken implementation of getaddrinfo() which doesn't handle "0" as numeric service correctly. This patch adds a configure check for this case and changes all calling functions to only use getaddrinfo() if it "works". See

portabtest: Only use one exit code to indicate errors

Fix spelling

portabtest: Code cleanup

doc/Platforms.txt: Add and update more systems - add i386/unknown/netbsdelf1.5.2, egcs-1.1.2 - update i386/unknown/openbsd5.3, gcc 4.2.1 - add i386/unknown/openbsd5.4, gcc 4.2.1 - add x86_64/unknown/linux-gnu, nwcc 0.8.2 - update x86_64/unknown/linux-gnu, tcc 0.9.25 Thanks to Götz Hoffart !

Fix permanent k/gline Reported by Toni Spets (hifi - at - jnz - dot - fi).

doc/Platforms.txt: Add and update more systems - add i386/unknown/openbsd3.5, gcc 2.95.3 - add x86_64/unknown/linux-gnu, Sun C 5.12 - update mipsel/unknown/linux-gnu, gcc 4.4.5 Thanks to Götz Hoffart !

doc/Platforms.txt: add DragonflyBSD 3.4 on x86_64 Thanks to Götz Hoffart !

doc/Platforms.txt: add OpenBSD 5.4 on HPPA

configure: clean up function definitions

Only use unsetenv() when it is available AIX 4.3 dosn't support it, for example.

conf-ssl.h: make code compatible with pre-ANSI C compilers

vsnprintf.c: make code compatible with ansi2knr tool

Remove unused vsnprintf.c test function

Add comments around some IRC_SetPenalty() calls

Rework the penalty handling slightly Increase the penalty for a command before checking its arguments. This makes the handling more consistent and allow us to move more penalties to Handle_Request().

Move IRC_SetPenalty() to Handle_Request() when possible This centralizes the penalty handling. It also exposes some commands that lack it for our attention.

Introduce a macro to define the command list This will pave the way to other changes and simplifies the entries somewhat.

When sending an error use the IRC_WriteErrClient() variant This ensures that all errors have a 2 second penalty.

On bad /oper set the penalty to 10 seconds This helps against brute-force attempts.

Remove unneded IRC_SetPenalty() calls IRC_WriteErrClient() already calls IRC_SetPenalty(). While here convert some IRC_SetPenalty() + IRC_WriteStrClient() to IRC_WriteErrClient().

Use sizeof() intead of the explicit size

Remove wrong #ifdef in Option_String() This fixes the following error when compiling without zlib support: irc.c: In function ‘Option_String’: irc.c:487: error: ‘options’ undeclared (first use in this function) Reported by "der_baer" on #ngircd.

NEWS/ChangeLog: Clean up version numbers and release dates

ngIRCd Release 21

doc/Platforms.txt: add Mac OS X 10.6.8

Update doc/Platforms.txt

ngircd.init: Make sure no stale PID file is left over

platformtest.sh/Platforms.txt: allow user names up to 8 characters

Check and call arc4random_stir() if present FreeBSD prior to 10.0 does not automatically stir on fork(). Same with current NetBSD. If arc4random_stir() is present assume is needed and call it instead of srand().

Debian: Fix sed(1) rules adjusting "ngircd-full" package Error introduced by last commit :-/

Debian: Fix default "HelpFile" file name in ngircd.conf The "full" package variants must use "/usr/share/doc/ngircd-full/Commands.txt" and "/usr/share/doc/ngircd-full-dbg/Commands.txt" respectively.

ngIRCd Release 21~rc2

platformtest.sh: Detect clang compilers

Add support for longer config lines With the introduction of CipherList we could have longer config lines. Handle up to 1024 bytes and warn if the line will be truncated.

Report the correct file on error

doc/Platforms.txt: Add Open64 and tcc C compilers on Linux Thanks to Götz Hoffart!

platformtest.sh: Detect tcc compiler

Add support for arc4random If arc4random is present it will be used over the srand/rand interface. This fixes some warnings in OpenBSD-current.

Fix another strcat warning missed in commit 4c5b43

platformtest.sh: Clean up GIT source tree, when possible

platformtest.sh: Detect Apple LLVM (clang) compiler

Update (date of) manual pages

ChnageLog file: even more spelling fixes ...

INSTALL file: Update "Upgrade Information"

Fix spelling in NEWS and ChangeLog files

ngircd.c, main(): use strlcat() instead of strcat() This fixes the following warning on OpenBSD 5.3: ngircd.o(.text+0xeb4): In function `main': src/ngircd/ngircd.c:300: warning: strcat() is almost always misused, please use strlcat() Thanks to Götz Hoffart for reporting this!

ngIRCd Release 21~rc1

Update NEWS and ChangeLog files

Actually KILL clients on GLINE/KLINE Kill all clients that match a new GLINE/KLINE mask and genrate apropriate KILL commands. These KILL commands can be superfluous, but are required when the IRC Operator isn't allowd to set remote G-Lines or if there are older servers in the network that don't kill clients on GLINE/KLINE. Closes bug #156.

Don't forward KILL commands for unknown clients

New function IRC_KillClient() to kill clients The old local function Kill_Nick() in irc.c has been an ugly hack. This patch implements a generic function for killing clients. Adjust all callers of Kill_Nick() and respect the return code!

Adjust log messages for invalid and spoofed prefixes Now invalid prefixes aren't logged no more when originating from an other server (besides in debug mode), and spoofed prefixes are correctly logged using LOG_WARNING (from an other server) or LOG_ERR (from a client) levels. In addition, the log message texts have been adjusted to better reflect what will happen: commands with invalid prefixes are ignored and logged, commands with spoofed prefixes will result in the client being disconncted (regular users) or the command being ignored (other servers). This cleans up logging of commands related to already KILL'ed clients.

Remove CLIENT.oper_by_my, Client_SetOperByMe() and Client_OperByMe() All places where Client_OperByMe() is used can either be converted to Client_HasMode(Client, 'o') or Op_Check(). And Op_Check() itself can use the connection handle for deciding whether the IRC Operator is a local user or not.

Add support to show user links using "STATS L" Change "stats L" to show servers and user links and restrict it to IRC Operators.

Log an error (not info) when working directory can't be changed

doc/PAM.txt: add a slightly more useful example

Change the certificate fingerprint digest to sha256 While here correct some indentation.

Change cipher defaults Switch cipher defaults to HIGH:!aNULL:@STRENGTH (OpenSSL) or SECURE128 (GnuTLS).

Merge remote-tracking branch 'alex/bug162-SSLCipherList' * alex/bug162-SSLCipherList: Cipher list selection for GnuTLS ConnSSL_Init_SSL(): correctly set CONN_SSL flag Cipher list selection for OpenSSL ConnSSL_InitLibrary(): Code cleanup

Fix server reconnection In some error cases conn_id will be left as SERVER_WAIT and subsequently ignored in Check_Servers(). Ensure conn_id is set to NONE before returning from New_Server() if we couldn't establish the connection. Prompted by a report from gabrielgi-at-gmail-dot-com.

Cipher list selection for GnuTLS This patch implements the missing functionality for cipher list selection using GnuTLS (our OpenSSL code has this already).

Don't ignore SSL-related errors during startup Without this patch, ngIRCd ignores SSL-related messages and continues to start up but only listens on plain text communication ports -- and this most probably isn't what the administrator wanted ... Closes bug #163.

ConnSSL_Init_SSL(): correctly set CONN_SSL flag The CONN_SSL flag must be set before any calls to ConnSSL_Free()!

Cipher list selection for OpenSSL This patch introduces the possibility to arbitrarily select ciphers which should be promoted resp. declined when establishing a SSL connection with a client by implementing the new configuration option "CipherList". By default, OpenSSL would accept low and medium strength and RC-4 ciphers, which nowadays are known to be broken. This patch only implements the feature for OpenSSL. A GnuTLS counterpart has to be implemented in another patch ... Original patch by Bastian . Closes bug #162.

TRACE: fix error message when there are too many parameters ircd 2.11 ignores additional parameters silently, but I don't think that this is the correct behaviour either ...

ConnSSL_InitLibrary(): Code cleanup

IRC_SetPenalty(): Code cleanup

Add more penalty times Ensure before every numeric 461 there is a call to IRC_SetPenalty().

Rework check for number of parameters Move most of the checks that return numeric 461 into Handle_Request().

Reorder checks Move oper and Conf_MorePrivacy checks after checking the number of parameters.

Move the IRC_SetPenalty() call after the asserts

Correct numeric returned by whois As per RFC whois should return 431 if no nick is provided. While here convert upper check to use irc-macros. As a bonus we get to set the penalty for free.

Minor cosmetic change Add a define to indicate any client. While I'm here use hex values instead of decimal, it's somewhat clearer that they could be OR'ed together.

Commands.txt: Document proprietary DIE parameter

getpid.sh: use /bin/pidof when available

Don't enforce channel types for other servers The configuration option "AllowedChannelTypes" must only be enforced for regular clients and not for remote servers. Channels created by other servres are always allowed, because they already exist and the daemon must stay in sync with the network.

Only log "IDENT ... no result" when IDENT was looked up Without this patch, ngIRCd logged the "IDENT lookup for connection X: no result"-message even when IDENT lookups have been disabled using the "Ident = no" configuration option, which is a little bit misleading. Reported by "btwe" in #ngircd.

ngircd: use setgid/setuid errno value in error path Need to use saved errno value as strerror argument, else you get bogus output ('success') in the log message.

Show connection flag "s" (SSL) in RPL_TRACE{LINK|SERVER} Now you can check if a server-to-server link is SSL-encrypted or not using the IRC "TRACE" command. Idea by Götz Hoffart, thanks!

Change away to be allocated dynamically

Ignore "operation not permitted" while dropping groups Without this exception, you can't start ngIRCd as user any more, it is analog to setting the user and group ID.

ngircd: discard supplementary group ids on startup The intention was to switch to JUST uid:gid, but setgid is not sufficient. Reported-by: Michael Scherer

Xcode: update project settings for Xcode 5

Merge branch 'bug159-WebircIPA' * bug159-WebircIPA: Introduce Free_Client() function to free CLIENT structure Save client IP address text for "WebIRC" users

Introduce Free_Client() function to free CLIENT structure

Implement new configuration option "DefaultUserModes" The new configuration option "DefaultUserModes" lists user modes that become automatically set on new local clients right after login. Please note that only modes can be set that the client could set on itself, you can't set "a" (away) or "o" (IRC Op), for example! User modes "i" (invisible) or "x" (cloaked) etc. are "interesting", though. Default: set no modes (like without this patch). Closes bug #160.

Save client IP address text for "WebIRC" users This patch introduces a new field in the CLIENT structure, "ipa_text", which points to an optional textual representation of the client IP address (or NULL) which can be used to store the "real" IP address information of a client using the "WEBIRC" protocol. Without this patch, ngIRCd ignored the paramater ... In addition, the functions Client_SetIPAText() and Client_IPAText() have been introduced to set and get the textual representation of the client IP address. Client_IPAText() can be used even when no "IP address text" has been set before, it then returns the real IP address of the connection. Closes bug #159.

Change strdup() to strndup()

private strndup() implementation in case libc does not provide it

Cosmetic changes to METADATA Update certfp and sort entries.

Silence warning Cast the result of the operation to long, not the time(NULL) call. On systems where sizeof(time_t) is other than long this will produce a warning.

Plug memory leak

Implement account login support This is done via the `accountname' METADATA command and used to automatically identify users after netsplits or across service restarts.

Fix spelling

ngIRCd Release 20.3 (cherry picked from commit bb6e2779636aa6d74bbff474880829f0183a3c94) Conflicts: ChangeLog NEWS

Correctly handle return code of Handle_Write() There have been code paths that ignored the return code of Handle_Write() when sending "notice auth" messages to new clients connecting to the server. But because Handle_Write() would have closed the client connection again if an error occurred, this would have resulted in new errors and assert()'s later on that could have crashed the server (denial of service). Only setups having the configuration option "NoticeAuth" enabled are affected, which is not the default. CVE-2013-5580.

Enhance log messages on "recursive" connection errors

Add some assert() calls to ng_ipaddr library

Update ChangeLog file

Debian init script: test for binary after reading defaults This allows the system administrator to overwrite the DAEMON variable in /etc/defaults/ and to use this init script even when the default "/usr/sbin/ngircd" doesn't exist on the system.

Merge branch 'ssl-log-messages' * ssl-log-messages: Make SSL-related log messages more readable ConnSSL_HandleError: Code cleanup, more documentation

Make SSL-related log messages more readable - Don't use internal function names but describe the error. - Streamline wording, use "SSL" for SSL and TLS. - Streamline punctuation.

Use _IRC_ARGC_BETWEEN_OR_RETURN_ when possible

ConnSSL_HandleError: Code cleanup, more documentation

Change log level of "SSL connection shutting down"

Fix 2 bugs introduced in 74514b8c23 Channel_Modes() and Channel_Topic() return static memory that is zeroed at creation time. Fix checking for empty modes and topic so they're propagated correctly.

configure: Don't quote IO backend type(s) It's not needed and inconsistent compared to the other settings. Reported by "allerbest" (Götz Hoffart) on #ngircd, thanks!

IRC_SERVER(): Code cleanup

Introduce new function IRC_WriteErrClient() This function is used to send "error messages", including numerics, back to clients and to automatically enforce a 2 second penalty. With this patch, all error results enforces a delay for the client. All callers of IRC_WriteStrClient(ERR_xxx) have been converted. Please note that this patch prolongs the time "make check" needs to complete its tests, because of lots of new enforced penalties ...

irc-macros.h: Update copyright, don't forget contributors!

irc-write.c: Clean up code and add more documentation comments

Fix return code of some IRC_WriteXXX() functions These functions usually write to more than one target, and therefore can't return value indicating success or failure in a sane way. And, even more omportant, these functions should send to as much as possible clients and not stop at the first client which isn't reachable any more!

Streamline punctuation of log messages See commit d38d153f for details.

Update NEWS and ChangeLog files

More spelling corrections

Inline who_flags_status

Convert more code to use Channel_HasMode

Simplify mode checking on channels and users within a channel Add Channel_HasMode() and Channel_UserHasMode() and use it where possible.

Use Client_HasMode and Client_HasFlag where appropriate

Merge branch 'bug152-AllowedChannelTypes' * bug152-AllowedChannelTypes: Implement new configuration option "AllowedChannelTypes" Introduce "CHANTYPES" #define

Implement new configuration option "AllowedChannelTypes" The new configuration variable "AllowedChannelTypes" lists all allowed channel types (channel prefixes) for newly created channels on the local server. By default, all supported channel types are allowed. If set to the empty string, local clients can't create new channels at all, which equals the old "PredefChannelsOnly = yes" setting. This patch deprecates the "PredefChannelsOnly" variable, too, but it is still supported and translated to the apropriate "AllowedChannelTypes" setting. When "PredefChannelsOnly" is processed, a warning message is logged. Closes bug #152.

More spelling fixes Remove superflous comments, mostly in German. Fix spelling and use american variants for consistency.

Change cloaked hostname to be malloc'd on demand This shaves a few bytes when cloaked hostnames are not used and restricts the cloakhost announcement iif there is something to send.

Introduce "CHANTYPES" #define This #define lists all the prefix characters of all supported channel types, this is "#&+" at the moment.

Add Client_HasFlag() to check if a client has certain flag

Merge remote-tracking branch 'fgsch/certfp' * fgsch/certfp: Simplify MOTD handling Add certificate fingerprint support

Fix spelling

Simplify MOTD handling Merge Show_MOTD_Start, Show_MOTD_Sendline and Show_MOTD_End into IRC_Show_MOTD.

Update irc-server.c to use irc-macros.h And add some comments :-)

Rename XXX_Fingerprint to XXX_CertFp

Add certificate fingerprint support

Commands.txt: Update more descriptions Update description of "CHANINFO", "METADATA", "NJOIN", "SERVER", "SQUIT", "GET", and "POST".

Improved client announcement Move Announce_User() to client.c and rename it to Client_Announce(). Use this in cb_introduceClient() instead of duplicating the code. This fix the certificate fingerprint announcement for new clients. Also ensure the certificate fingerprint is only announced if the client supports it (`M' flag).

Update irc-oper.c to use irc-macros.h

Add penalty times in error paths of generic IRC helper macros Add a 2 second penalty time when the number of parameters is invalid.

Commands.txt: Update more descriptions Update description of "CONNECT", "DIE", "DISCONNECT", "GLINE", "KILL", "KLINE", "OPER", "REHASH", "RESTART" and "WALLOPS".

Add more penalty times in error paths This patch changes the handlers of the "PASS", "NICK", "USER", and "SERVICE" commands to enforce a 2 second penalty when an error like "need more/other parameters" occurs. More functions should follow, I think ...

Commands.txt: Fix description of TRACE command

Update irc-login.c to use irc-macros.h This includes code cleanups, too :-)

Update irc-mode.c to use irc-macros.h This includes code cleanups and more comments, too.

Commands.txt: Update more descriptions Update descriptions of "NICK", "PASS", "PING", "PONG", "QUIT", "USER", "WEBIRC", "SERVICE", and "SVSNICK".

Update irc-channel.c to use irc-macros.h This includes code cleanups, too :-)

Commands.txt: Update description of "PRIVMSG", "NOTICE", and "SQUERY"

Commands.txt: Update more descriptions Update descriptions of "AWAY", "JOIN", "LIST", "MODE", "PART", "TOPC", and "TRACE".

Add "compile" to .gitignore file

Commands.txt: Streamline references to IRC+ protocol

Commands.txt: Update description of the "ERROR" command

Show IRC Operator name when logging a successful OPER command

Update irc.c to use irc-macros.h This includes code cleanups and better documentation for some functions, too.

Merge pull request #4 from fgsch/master Changes for ngircd 21.

Handle services in IRC_WHOIS_SendReply() If the target is a service, advertise it as such and ignore operator mode.

Slightly update ngircd.8 manual page

Fix spelling

Travis-CI: Enable OpenSSL and libiconv support

Updated NEWS and ChangeLog files

Enhance Travis-CI configuration file It now configures the sandbox to build ngIRCd with IPv6, IDENT, PAM, TCP-Wrappers, and zlib support. And it installs expect(1) and telnet(1) for the test suite.

Merge pull request #3 from Cofyc/master irc-info.c: some commands use LINE_LEN as command buffer len

LINE_LEN -> COMMAND_LEN LINE_LEN is configuration file line length

IncludeDir: default to "$SYSCONFDIR/ngircd.conf.d" Now "IncludeDir" defaults to "$SYSCONFDIR/ngircd.conf.d" instead of no directory, but a missing directory is only reported as an error if it has explicitely configured in the main configuration file and simply ignored otherwise. Therefore it is now possible not to touch the default (sample) configuration file at all, and set all distribution and/or system specific configuration options in "*.conf" files stored in "$SYSCONFDIF/ngircd.conf.d/". Thanks to "Elmasloco" for the idea!

"IncludeDir" can't be overwritten by included files

Rename "Mask" variables into "Pattern" in assert() statements This completes commit 3ab00e3a11 which broke debug builds.

Implement new configuration option "IncludeDir" The option "IncludeDir" in the [Options] section can be used to specify a directory which can contain further configuration files and configuration file snippets matching the pattern "*.conf" that should be read in after the main configuration file ("ngircd.conf" by default) has been parsed. Closes bug #157.

Ensure there is enough space for the mask As pointed by Alex while strl{cat,cpy} take the full length we need to leave space to ensure a proper mask is always created so revert the removal of - N from my last change.

conf.c: New function Read_Config_File() This function reads in and parses a single configuration file. Adjust all other functions to display the correct name of the file being read in currently.

Better description for Lists_CheckReason()

Change Lists_MakeMask() to receive a buffer for the mask Change callers accordingly so they don't rely on a global buffer and rename Mask to Pattern where it makes sense since some functions where indeed receiving a pattern and not a mask.

Fix use-after-free on Lists_CheckReason() Change Lists_CheckReason() to receive a buffer where the reason will be stored and its length. Change callers accordingly. Change Class_GetMemberReason() (and its callers) in a similar way so it doesn't rely on a global buffer for the rejected reason.

Update doc/Platforms.txt a little bit ...

Build OS X package with correct file permissions This requires to have the correct permissions in the source tree, which is "root:wheel", which in turn requires root privileges. Therefore the Makefile now tries to become root on "make osxpkg-dest" but tries hard not to require root privileges on "clean" etc.

Xcode: fix detection of host OS, vendor, and CPU

PackageMaker: use relativ path names

Add Travis-CI configuration file

Make configure[.ng] compatible with autoconf 1.10 again The incompatibility has been introduced by commit d0c9f4a6, "configure: search for iconv_open as well as libiconv_open".

Lists_CheckReason(): Check for Client_MaskCloaked() Look for possible cloaked Masks in Lists. Users with +x usermode can be banned with their cloaked hostname now.

Services.txt: Anope 1.9.8 has been released now

Commands.txt: Update description of the "KILL" command

Conn_Handler(): Don't test for penalty times The Conn_Handler() main loop calls Handle_Buffer() which checks for the "penalty time" of each client itself, so don't do it twice.

Don't read SSL client data before DNS resolver is finished Fix the cb_clientserver_ssl() callback function to not read in and store SSL encrypted client data before the asynchronous DNS resolver sub-process has finished: This could have resulted in discarding the resolved client hostname and IDENT reply afterwards, because in some situations (timing dependent) the NICK and USER commands could have already been read in from the client, stored in the buffer, and been processed. Thanks to Julian Brost for reporting the issue and testing, and to Federico G. Schwindt for helping to debug it!

Increase password length limit to 64 characters Closes bug #154.

doc/Services.txt: Update Anope status and URL

Commands.txt: Update description of the "KICK" command

Commands.txt: Update description of the "INVITE" command

irc-op.c: use irc-macros.h

irc-cap.c: use irc-macros.h

irc-op.c: Update source code documentation

irc-cap.c: Update source code documentation

Add new _IRC_ARGC_EQ_OR_RETURN_ macro to irc-macros.h

Add new _IRC_ARGC_BETWEEN_OR_RETURN_ macro to irc-macros.h

irc-cap.c: move static functions to the top of the file And remove now unnecessary (local) prototypes.

Update Doxygen configuration

Clean up Xcode project file, remove outdated files, add missing

src/testsuite/README: add whois-test.e

irc-login.c: conenction -> connection Introduced by commit d3ef2239 as of Sun Jan 16 2011 ... Thanks to Patrik Schindler for reporting this!

Merge branch 'bug151-iconv' into master * bug151-iconv: configure: search for iconv_open as well as libiconv_open

Merge branch 'bug153-ServerMask' into master * bug153-ServerMask: Update irc-info.c to use irc-macros.h Add new irc-macros.h to project irc-info.c: add/streamline function documentation comments irc-info: move static functions at the top of the file Implement new function Client_SearchServer() Conflicts: src/ngircd/irc-info.c

configure: search for iconv_open as well as libiconv_open On some installations iconv_open() is actually libiconv_open(). iconv_open() is the glibc version while libiconv_open() is the libiconv version. This patch enables ngIRCd to detect both cases. Tested on OpenBSD 5.1. Closes bug #151.

configure: conversation -> conversion

Update irc-info.c to use irc-macros.h This includes: - move IRC_SetPenalty() at the beginning of the handler functions, - use macros provided by irc-macros.h, - code cleanup. The main benefits of this patch are core size reduction, streamlined structure of the handler functions, and enhanced functionality: because of the _IRC_GET_TARGET_SERVER_OR_RETURN_() macro using the Client_SearchServer() function, the target of the specific IRC command can now be given server names, server mask, or the nickname of a user connected to the server. Closes bug #153.

ngIRCd Release 20.2 (cherry picked from commit c45d9dd1f08fddb95fa01d62c69848cd753a3161)

Add new irc-macros.h to project This file prvides some macros for common tasks required by functions implementing handlers for IRC commands: * _IRC_ARGC_LE_OR_RETURN_ * _IRC_ARGC_GE_OR_RETURN_ * _IRC_GET_SENDER_OR_RETURN_ * _IRC_GET_TARGET_SERVER_OR_RETURN_

KICK: Fix denial of service bug Test if the user that it is to be kicked is on the channel before user channel modes are tested. Otherwise assert( cl2chan != NULL ); in line 742 would fail and stop the service.

irc-info.c: add/streamline function documentation comments Add missing comments, streamline wording, and remove references to the RFCs: this will be added to ./doc/Commands.txt with an other patch and we want to avoid redundancy ...

sighandlers.c: Update some log messages

irc-info: move static functions at the top of the file

my_sd_listen_fds(): really return an "int" This fixes the following warning using Apple LLVM version 4.2 (clang-425.0.24) on OS X: src/ngircd/conn.c:157:9: Implicit conversion loses integer precision: 'long' to 'int'

Implement new function Client_SearchServer() This function returns the server structure of a client or a given "mask"; it is useful for implemention handlers for commands like "COMMAND *.net", which should work on a server matching "*.net". Please note that the local server is always returned when it matches the mask, but besides that, the order is completely arbitrary.

Merge branch 'bug155-allowAtInUser' * bug155-allowAtInUser: Allow "@" character in user names for authentication