Commit Diff
Diff:
25e56a5e837173a567a0873bd5a9ccc126cff333
20ddffca0d5ae5393adc57b67ba90e15d33e2ee3
Commit:
20ddffca0d5ae5393adc57b67ba90e15d33e2ee3
Tree:
d8b1a41aa52924f2cb6df126fc8528c9dd8e1c0c
Author:
Alexander Barton <alex@barton.de>
Committer:
Alexander Barton <alex@barton.de>
Date:
Mon Dec 31 17:13:18 2012 UTC
Message:
Mode setting: only check channel user modes when on channel Only check the channel user modes of the initiator if he is joined to this channel and not an IRC operator enforcing modes (which requires the configuration option "OperCanUseMode" to be enabled), because trying to check channel user modes of a non-member results in this assertion: Assertion failed: (cl2chan != NULL), function Channel_UserModes, file channel.c, line 742. This closes bug #147, thanks to James Kirwill for tracking this down!
blob - 32219975f5ea23a389fcc368551104e331226155
blob + a63a0f411bc95a4320fa2bc9a47ff84d176bcc49
--- src/ngircd/irc-mode.c
+++ src/ngircd/irc-mode.c
@@ -550,7 +550,7 @@ Channel_Mode(CLIENT *Client, REQUEST *Req, CLIENT *Ori
if (arg_arg >= Req->argc)
arg_arg = -1;
- if(!is_machine) {
+ if(!is_machine && !is_oper) {
o_mode_ptr = Channel_UserModes(Channel, Client);
while( *o_mode_ptr ) {
if ( *o_mode_ptr == 'q')
IRCNow