Commit Diff
Diff:
7cda2f13f48d7cd09df5644c44ed222e81029289
2254e92e60fbe09da5adef1111ddcd60b7e98252
Commit:
2254e92e60fbe09da5adef1111ddcd60b7e98252
Tree:
8d841fab96affa224bc1fdd78d1e3546ff5791c0
Author:
Alexander Barton <alex@barton.de>
Committer:
Alexander Barton <alex@barton.de>
Date:
Sun Jan 10 16:39:43 2016 UTC
Message:
platformtest.sh: Only show "runs=Y" when test suite succeeded Display "?" in the "runs" colum when the simple "run test" succeeded but the test suite failed. And display a message to double check the actual status, because it is somewhat unclear, if the daemon actually "works" or not in this case.
blob - 8a861716d7d95a0795e09d15b6d11cfd449bb108
blob + 4e28f92542caa65c675b64e24c6c266b4d0f60ba
--- contrib/platformtest.sh
+++ contrib/platformtest.sh
@@ -189,7 +189,12 @@ fi
[ -n "$R_CONFIGURE" ] && C="Y" || C="N"
[ -n "$R_MAKE" ] && M="Y" || M="N"
[ -n "$R_CHECK" ] && T="$R_CHECK_Y" || T="N"
-[ -n "$R_RUN" ] && R="Y" || R="N"
+if [ -n "$R_RUN" ]; then
+ # Mark "runs" with "Y" only when the test suite succeeded:
+ [ "$T" = "N" ] && R="?" || R="Y"
+else
+ R="N"
+fi
[ -n "$COMMENT" ] && COMMENT=" $COMMENT"
echo
@@ -210,7 +215,19 @@ else
"$C" "$M" "$T" "$R" "$COMMENT"
fi
echo
+
+double_check() {
+ echo "Please double check that the ngIRCd daemon starts up, runs and handles IRC"
+ echo "connections successfully!"
+}
+
if [ "$R_CHECK_Y" = "y" ]; then
- echo "$NAME: WARNING: Some tests have been skipped!"
+ echo "WARNING: Some tests have been skipped!"
+ double_check
echo
fi
+if [ "$R" = "?" ]; then
+ echo "WARNING: The resulting binary passed simple tests, but the test suite failed!"
+ double_check
+ echo
+fi
IRCNow