Commit Diff

Commit:
25e56a5e837173a567a0873bd5a9ccc126cff333
From:
Alexander Barton <alex@barton.de>
Date:
Message:
Add some more casts in assert() statemens This fixes the following warning messages of gcc 4.5.3 on Cygwin when building with debug code enabled: ng_ipaddr.c: In function ‘ng_ipaddr_init’: ng_ipaddr.c:52:2: warning: comparison between signed and unsigned integer expressions ng_ipaddr.c:53:20: warning: comparison between signed and unsigned integer expressions resolve.c: In function ‘ForwardLookup’: resolve.c:271:3: warning: comparison between signed and unsigned integer expressions
Actions:
Patch | Tree
commit - 1e5a7aac877f2b5d105d8cb291b107217b140632
commit + 25e56a5e837173a567a0873bd5a9ccc126cff333
blob - 05ef6ecb19263f9b602fcbf7d46f3c7a51ad1150
blob + 9cf35ec976325f312dc30672ad8e8fc417b96e90
--- src/ipaddr/ng_ipaddr.c
+++ src/ipaddr/ng_ipaddr.c
@@ -49,8 +49,8 @@ ng_ipaddr_init(ng_ipaddr_t *addr, const char *ip_str, 
 	if (ret != 0)
 		return false;
 
-	assert(sizeof(*addr) >= res0->ai_addrlen);
-	if (sizeof(*addr) >= res0->ai_addrlen)
+	assert(sizeof(*addr) >= (size_t)res0->ai_addrlen);
+	if (sizeof(*addr) >= (size_t)res0->ai_addrlen)
 		memcpy(addr, res0->ai_addr, res0->ai_addrlen);
 	else
 		ret = -1;
blob - 3f99b3a90178ede568e5212352cf78839db6a5f4
blob + 6078da8b48a9b6adecec99761f9ea7c2ec1f2188
--- src/ngircd/resolve.c
+++ src/ngircd/resolve.c
@@ -268,7 +268,7 @@ ForwardLookup(const char *hostname, array *IpAddr, int
 	}
 
 	for (a = ai_results; a != NULL; a = a->ai_next) {
-		assert(a->ai_addrlen <= sizeof(addr));
+		assert((size_t)a->ai_addrlen <= sizeof(addr));
 
 		if ((size_t)a->ai_addrlen > sizeof(addr))
 			continue;