Commit Diff

Commit:
ee5f8f670f4d7f82e47bcf75c53b91fca4b1a137
From:
Markus Uhlin <markus@nifty-networks.net>
Date:
Message:
Fixed possible buffer overflow
Actions:
Patch | Tree
commit - 22a1ccf7a3afa9c2e3e5565a5698bf970a748697
commit + ee5f8f670f4d7f82e47bcf75c53b91fca4b1a137
blob - b5f40d96b99f9963c9e6ad33731d8bcf80f1ece3
blob + d9381e129ba08402e568e0ebd6c7abf81cc08e28
--- FICS/playerdb.c
+++ FICS/playerdb.c
@@ -2431,10 +2431,13 @@ SaveThisMsg(int which, char *line)
 	char	Sender[MAX_LOGIN_NAME] = { '\0' };
 	int	p1;
 
+	_Static_assert(19 < ARRAY_SIZE(Sender), "Array too small");
+
 	if (which == 0)
 		return 1;
 
-	sscanf(line, "%s", Sender);
+	if (sscanf(line, "%19s", Sender) != 1)
+		warnx("%s: failed to read sender");
 
 	if (which < 0) {
 		p1 = (-which) - 1;