Commit Diff

Commit:
ffad2da835e26a1a457d4f4a16acf6797d4cc71e
From:
Alexander Barton <alex@barton.de>
Date:
Message:
Correctly check that a server has a valid hostname and port David Binderman <dcb314@hotmail.com> reported the following compiler warning, which is a real bug in ngIRCd, thanks! conn.c:2077:55: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
Actions:
Patch | Tree
commit - 3f1547ecdec24fd685f05e40733ae0d907bcb9d8
commit + ffad2da835e26a1a457d4f4a16acf6797d4cc71e
blob - 5c175dfd26e1bec492c2cb545296d6c37c58a55e
blob + 62561544866413f5abb1534da27caac1e2aa2218
--- src/ngircd/conn.c
+++ src/ngircd/conn.c
@@ -1904,7 +1904,7 @@ Check_Servers(void)
 	for (i = 0; i < MAX_SERVERS; i++) {
 		if (Conf_Server[i].conn_id != NONE)
 			continue;	/* Already establishing or connected */
-		if (!Conf_Server[i].host[0] || !Conf_Server[i].port > 0)
+		if (!Conf_Server[i].host[0] || Conf_Server[i].port <= 0)
 			continue;	/* No host and/or port configured */
 		if (Conf_Server[i].flags & CONF_SFLAG_DISABLED)
 			continue;	/* Disabled configuration entry */