commit 93d812f08b1a4275c6979044d1d13c6049330616
from: Markus Uhlin <markus@nifty-networks.net>
date: Sun Apr  6 17:55:03 2025 UTC

Fixed dead stores

commit - e169863f566fe3e02cc721d5bedd036ed02beef5
commit + 93d812f08b1a4275c6979044d1d13c6049330616
blob - fae75a92a96fd57ec2d4a3feae9b4f6127d09aef
blob + 7bae2780ae68b09525521ec77fdb8fab0002ec50
--- FICS/playerdb.c
+++ FICS/playerdb.c
@@ -665,14 +665,13 @@ ReadV1PlayerFmt(int p, player *pp, FILE *fp, char *fil
 				return;
 			}
 
-			if (!(len = strlen(tmp2))) {
+			if (!strlen(tmp2)) { // XXX
 				fprintf(stderr, "FICS: Error bad alias in "
 				    "file %s\n", file);
 				i--;
 				pp->numAlias--;
 			} else {
 				tmp2[strcspn(tmp2, "\n")] = '\0';
-				tmp = tmp2;
 				tmp = eatword(tmp2);
 				*tmp = '\0';
 				tmp++;
@@ -942,7 +941,7 @@ got_attr_value_player(int p, char *attr, char *value, 
 					return -1;
 				}
 
-				if (!(len = strlen(tmp))) {
+				if (!strlen(tmp)) { // XXX
 					fprintf(stderr, "FICS: Error bad alias "
 					    "in file %s\n", file);
 					i--;
@@ -2834,7 +2833,7 @@ player_show_messages(int p)
 PUBLIC int
 ShowMsgsBySender(int p, param_list param)
 {
-	int		 nFrom, nTo;
+	int		 nFrom = -1, nTo = -1;
 	int		 p1, connected;
 	textlist	*Head;
 
@@ -2847,8 +2846,6 @@ ShowMsgsBySender(int p, param_list param)
 		return -1; /* no need to disconnect */
 	}
 
-	nFrom = nTo = -1;
-
 	if (p != p1) {
 		if ((nTo = LoadMsgs(p1, p + 1, &Head)) <= 0) {
 			pprintf(p, "%s has no messages from you.\n",